Skip to content

fix(settings): rename credentials to secrets, align role display#4364

Merged
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/secrets-page-error
Apr 30, 2026
Merged

fix(settings): rename credentials to secrets, align role display#4364
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/secrets-page-error

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Rename credentials/ folder/files/components to secrets/ to match the page name
  • Replace Badge with disabled Combobox for non-admin role display in Secrets and Integrations details views; widen to full-width when no admin actions are present
  • Reorder integrations credential row buttons so Details is always rightmost (Disconnect on left)
  • Split skeletons: page-level becomes secrets-skeleton.tsx, row-level moves to integrations/credential-skeleton.tsx
  • Minor cleanup: trivial useMemo → const, ROLE_OPTIONS constant, --success--text-success token

Test plan

  • Open /workspace/[id]/settings/secrets as admin and as a non-admin member; verify role Combobox is disabled for non-admins and full-width when no admin actions show
  • Open /workspace/[id]/settings/integrations details view; verify same role Combobox behavior and that Details button is rightmost
  • Confirm dynamic-import skeleton renders match the loaded component layouts

🤖 Generated with Claude Code

- Rename credentials/ folder to secrets/ to match the page name
- Replace Badge with disabled Combobox for non-admin role display in secrets and integrations details views, full-width when no admin actions
- Reorder integrations credential row buttons so Details is rightmost
- Split credential-skeleton: page-level moves to secrets-skeleton, row-level moves to integrations/credential-skeleton
- Cleanup: useMemo→const where deps were trivial, ROLE_OPTIONS const, --text-success token

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Apr 30, 2026 9:12pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 30, 2026

PR Summary

Low Risk
Low risk UI/UX refactor limited to settings pages; main risk is broken dynamic imports/paths or minor layout regressions in secrets/integrations views.

Overview
Renames the Settings section implementation from credentials to secrets by swapping the dynamic import/route wiring to a new Secrets component and updating sidebar prefetch to load components/secrets/secrets.

Refactors skeletons by moving the integration row CredentialSkeleton into integrations/credential-skeleton.tsx and making secrets/secrets-skeleton.tsx a secrets-grid-specific page skeleton.

Polishes integrations/secrets details UI: standardizes ROLE_OPTIONS, simplifies some derived state, makes non-admin member roles render as a disabled Combobox with responsive column widths, and reorders integrations list actions so Details is always rightmost (with Disconnect to the left when present).

Reviewed by Cursor Bugbot for commit 55677a0. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 30, 2026

Greptile Summary

This PR renames the credentials/ folder and all related components to secrets/ to align with the page name, and improves the role display UX by replacing the static Badge with a disabled Combobox for non-admin users in both the Secrets and Integrations detail views. Secondary changes include splitting the skeleton components, reordering the credential row buttons so Details is always rightmost, de-memoizing trivial derived values, and updating the copy-icon CSS token from --success to --text-success.

Confidence Score: 5/5

Safe to merge — all changes are mechanical renames, UX alignment, and trivial cleanup with no logic regressions.

No P0 or P1 issues found. The rename is complete and consistent across all import sites, skeleton exports, and prefetch paths. The useMemo removals are on primitive-returning expressions with negligible performance impact, and the disabled Combobox replacement is a straightforward UI swap.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/settings/components/secrets/secrets-manager.tsx Renamed from credentials-manager; converted adminMemberCount and dirty-check booleans from useMemo to plain consts; replaced Badge role display with disabled Combobox; updated copy icon token to --text-success. Clean changes.
apps/sim/app/workspace/[workspaceId]/settings/components/integrations/integrations-manager.tsx CredentialSkeleton import moved to new location; adminMemberCount and dirty-check booleans de-memoized; button order swapped so Details is rightmost; non-admin grid widens to 2-col layout; text-sm → text-small. No issues found.
apps/sim/app/workspace/[workspaceId]/settings/[section]/settings.tsx Updated dynamic import to point to new secrets/ path and replaced CredentialsSkeleton with SecretsSkeleton — straightforward rename, no issues.
apps/sim/app/workspace/[workspaceId]/settings/components/secrets/secrets-skeleton.tsx Renamed from credential-skeleton; CredentialSkeleton extracted to integrations/ folder; SecretsSkeleton and SecretRowSkeleton renamed appropriately.
apps/sim/app/workspace/[workspaceId]/settings/components/integrations/credential-skeleton.tsx New file: CredentialSkeleton for integration credential rows, extracted from the old credential-skeleton.tsx into the integrations/ folder where it belongs.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["settings.tsx\n(dynamic import)"] -->|"section === 'secrets'"| B["secrets/secrets.tsx"]
    B --> C["secrets/secrets-manager.tsx\n(renamed from credentials-manager)"]
    A -->|"section === 'integrations'"| D["integrations/integrations-manager.tsx"]

    C -->|"loading skeleton"| E["secrets/secrets-skeleton.tsx\n(renamed from credential-skeleton)"]
    D -->|"loading skeleton"| F["integrations/integrations-skeleton.tsx"]
    F --> G["integrations/credential-skeleton.tsx\n(new — extracted from old credential-skeleton)"]

    H["settings-sidebar.tsx\n(prefetch)"] -->|"prefetch import"| B

    subgraph "Role Display (non-admin)"
        C --> I["disabled Combobox\n(was: Badge)"]
        D --> J["disabled Combobox\n(was: Badge + empty div)"]
    end
Loading

Reviews (1): Last reviewed commit: "fix(settings): rename credentials to sec..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant