fix(settings): rename credentials to secrets, align role display#4364
fix(settings): rename credentials to secrets, align role display#4364waleedlatif1 merged 1 commit intostagingfrom
Conversation
- Rename credentials/ folder to secrets/ to match the page name - Replace Badge with disabled Combobox for non-admin role display in secrets and integrations details views, full-width when no admin actions - Reorder integrations credential row buttons so Details is rightmost - Split credential-skeleton: page-level moves to secrets-skeleton, row-level moves to integrations/credential-skeleton - Cleanup: useMemo→const where deps were trivial, ROLE_OPTIONS const, --text-success token Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Refactors skeletons by moving the integration row Polishes integrations/secrets details UI: standardizes Reviewed by Cursor Bugbot for commit 55677a0. Configure here. |
Greptile SummaryThis PR renames the Confidence Score: 5/5Safe to merge — all changes are mechanical renames, UX alignment, and trivial cleanup with no logic regressions. No P0 or P1 issues found. The rename is complete and consistent across all import sites, skeleton exports, and prefetch paths. The useMemo removals are on primitive-returning expressions with negligible performance impact, and the disabled Combobox replacement is a straightforward UI swap. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["settings.tsx\n(dynamic import)"] -->|"section === 'secrets'"| B["secrets/secrets.tsx"]
B --> C["secrets/secrets-manager.tsx\n(renamed from credentials-manager)"]
A -->|"section === 'integrations'"| D["integrations/integrations-manager.tsx"]
C -->|"loading skeleton"| E["secrets/secrets-skeleton.tsx\n(renamed from credential-skeleton)"]
D -->|"loading skeleton"| F["integrations/integrations-skeleton.tsx"]
F --> G["integrations/credential-skeleton.tsx\n(new — extracted from old credential-skeleton)"]
H["settings-sidebar.tsx\n(prefetch)"] -->|"prefetch import"| B
subgraph "Role Display (non-admin)"
C --> I["disabled Combobox\n(was: Badge)"]
D --> J["disabled Combobox\n(was: Badge + empty div)"]
end
Reviews (1): Last reviewed commit: "fix(settings): rename credentials to sec..." | Re-trigger Greptile |
Summary
credentials/folder/files/components tosecrets/to match the page namesecrets-skeleton.tsx, row-level moves tointegrations/credential-skeleton.tsxuseMemo→ const,ROLE_OPTIONSconstant,--success→--text-successtokenTest plan
/workspace/[id]/settings/secretsas admin and as a non-admin member; verify role Combobox is disabled for non-admins and full-width when no admin actions show/workspace/[id]/settings/integrationsdetails view; verify same role Combobox behavior and that Details button is rightmost🤖 Generated with Claude Code