fix(serializer): apply tools.config.params before validating required tool params

[waleedlatif1]

Summary

• pre-execution validator was looking up tool param names directly on extracted params, but blocks that rename inputs in tools.config.params (canonical document → tool param file, e.g. firecrawl parse, reducto v2) only have the tool name after that mapper runs at execution time
• run the block's tools.config.params once on a shallow copy before validating, then check the mapped value with raw-params fallback — restores correct validation for canonical-rename blocks without changing behavior for any other block

Type of Change

• Bug fix

Testing

Tested manually + 97 serializer tests pass

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		May 2, 2026 1:53am

[cursor]

PR Summary

Medium Risk
Changes pre-execution required-field validation for tool-backed blocks by applying a params-mapping function first; incorrect mapping could cause workflows to fail validation or skip missing required inputs.

Overview
Pre-execution serializer validation for tool-backed blocks now runs the block’s tools.config.params mapper (with try/catch) and validates required user-only tool params against the mapped result instead of the raw extracted params.

This fixes false “missing required field” errors for blocks that rename canonical inputs to tool param names during execution, while falling back to raw params if the mapper throws.

^{Reviewed by Cursor Bugbot for commit afadcf5. Configure here.}

[greptile-apps]

Greptile Summary

Fixes a pre-execution validation false-negative: blocks that rename canonical inputs to tool param names via tools.config.params (e.g. Firecrawl Parse renaming document → file) were always reported as missing a required field because the validator read from the pre-mapper params object. The fix runs the mapper on a shallow copy of params before the loop, spreads the result into mappedParams, and reads mappedParams[paramId] instead — with a silent catch fallback to raw params if the mapper throws on placeholder values.

Confidence Score: 5/5

Safe to merge — targeted, well-guarded fix with no new failure modes introduced.

The change is minimal and surgical: one new try/catch block that maps params before validation, falling back to raw params on any error. Previous review feedback (array guard, redundant fallback removal) has been addressed. No P1 or P0 issues found.

No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/serializer/index.ts	Applies tools.config.params mapper before required-field validation so canonically-renamed params (e.g. document → file) are correctly resolved; mapper errors fall back to raw params safely.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Enter validateBlock] --> B{currentTool?}
    B -- No --> G[validate subBlocks only]
    B -- Yes --> C{tools.config.params is a function?}
    C -- No --> D[mappedParams = params]
    C -- Yes --> E[call mapper on shallow copy of params]
    E --> F{result is non-null non-array object?}
    F -- Yes --> H[mappedParams = spread params plus result]
    F -- No --> D
    E -- throws --> D
    D --> I[iterate tool.params entries]
    H --> I
    I --> J{param required and visibility=user-only?}
    J -- No --> I
    J -- Yes --> K{shouldValidateParam?}
    K -- No --> I
    K -- Yes --> L[check mappedParams at paramId]
    L --> M{undefined or null or empty?}
    M -- Yes --> N[push to missingFields]
    M -- No --> I

Loading

_{Reviews (2): Last reviewed commit: "fix(serializer): guard array results and..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit afadcf5. Configure here.}