Skip to content

improvement(lock): lock icon next to entity#4401

Merged
icecrasher321 merged 1 commit intostagingfrom
improvement/lock-icon
May 2, 2026
Merged

improvement(lock): lock icon next to entity#4401
icecrasher321 merged 1 commit intostagingfrom
improvement/lock-icon

Conversation

@icecrasher321
Copy link
Copy Markdown
Collaborator

Summary

Lock icon next to main entity being locked (folder vs workflow)

Type of Change

  • Other: UX Improvement

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped May 2, 2026 6:48am

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 2, 2026

PR Summary

Low Risk
Low risk UI-only change that adds a visual indicator for locked state; no behavior, permissions, or data mutations were modified.

Overview
Adds a small lock icon next to folder and workflow names in the sidebar when the entity is locked (hidden while renaming for workflows).

This imports and uses the shared Lock icon and includes accessible aria-labels for the new indicator.

Reviewed by Cursor Bugbot for commit b948add. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 2, 2026

Greptile Summary

This PR adds a small Lock icon (12×12 px) next to the entity name in the sidebar for both locked folders and locked workflows, providing a clear visual indicator of the locked state. The implementation is minimal and consistent across both components: pointer-events-none, flex-shrink-0, proper aria-label for accessibility, and the @/ path alias for the import.

Confidence Score: 5/5

Safe to merge — purely additive UI change with no logic or state impact.

Both changes are small, isolated conditional renders with no effect on existing logic, state, or data flow. Accessibility attributes are present and the import pattern follows the established @/ alias convention.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/folder-item/folder-item.tsx Adds a Lock icon next to the folder name when folder.locked is true, correctly placed inside the non-editing branch; uses proper path alias import.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/workflow-item/workflow-item.tsx Adds a Lock icon next to the workflow name when not editing and workflow.locked is true; icon is placed before Avatars in the flex row, consistent with existing layout patterns.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Render folder-item / workflow-item] --> B{isEditing?}
    B -- Yes --> C[Show rename input]
    B -- No --> D[Show name label]
    D --> E{folder.locked / workflow.locked?}
    E -- Yes --> F[Render Lock icon]
    E -- No --> G[Skip Lock icon]
    F --> H[Render Avatars / MoreHorizontal button]
    G --> H
Loading

Reviews (1): Last reviewed commit: "improvement(lock): lock icon next to ent..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant