Skip to content

fix(docker): drop scripts/ from workspaces array#4484

Merged
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/fix-scripts-workspace-prune
May 7, 2026
Merged

fix(docker): drop scripts/ from workspaces array#4484
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/fix-scripts-workspace-prune

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

@waleedlatif1 waleedlatif1 commented May 7, 2026

Summary

The Docker build is failing on staging after #4481 with:

error: Workspace not found "scripts"
    at /app/package.json:10:5

turbo prune sim --docker strips scripts/ from the pruned output (sim doesn't depend on it), but the pruned root package.json still listed it as a workspace, so bun install errors before it even starts.

scripts/ is dev-only tooling that runs from the repo root via bun run scripts/*.ts. Its imports (glob, yaml) resolve against the root node_modules — already in root devDependencies.

  • Remove "scripts" from root workspaces array
  • Delete scripts/package.json (no longer a workspace, manifest unused)

Test plan

  • bun install clean at root
  • bun run check:boundaries passes
  • bun run check:realtime-prune passes
  • bun run check:api-validation passes
  • Simulated Docker build locally: turbo prune sim --docker then bun install --ignore-scripts --linker=hoisted against the pruned output → 1856 packages installed cleanly
  • CI Docker build green

`turbo prune sim --docker` strips `scripts/` from the pruned output (sim
doesn't depend on it), but the pruned root package.json still listed it
as a workspace, causing `bun install` to fail with "Workspace not found
'scripts'" in the Docker build.

scripts/ is dev-only tooling that runs from the repo root via `bun run
scripts/*.ts`. Its imports (glob, yaml) resolve against the root
node_modules — they're already in root devDependencies.

- Remove "scripts" from root workspaces array
- Delete scripts/package.json (no longer a workspace, manifest unused)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Building Building Preview, Comment May 7, 2026 3:23am

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 7, 2026

PR Summary

Low Risk
Low risk config-only change that adjusts workspace/package metadata; main risk is any tooling that expected scripts to be its own workspace/package.

Overview
Fixes Docker/pruned monorepo installs by removing "scripts" from the root workspaces list so bun install no longer fails when turbo prune --docker omits that directory.

Deletes the unused scripts/package.json workspace manifest and drops the sim-doc-generator workspace entries from bun.lock.

Reviewed by Cursor Bugbot for commit 89c99e9. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 7, 2026

Greptile Summary

Fixes a Docker build regression introduced in #4481 where turbo prune sim --docker would strip scripts/ from its output but the pruned package.json still declared it as a workspace, causing bun install to abort with "Workspace not found". The fix de-registers scripts/ as a Bun workspace and deletes its now-unnecessary package.json.

  • \"scripts\" removed from the root workspaces array in package.json; the scripts continue to work because glob and yaml are already listed in root devDependencies and resolve from root node_modules.
  • scripts/package.json deleted and bun.lock updated to drop the sim-doc-generator workspace entry and its scoped glob@11.1.0 pin; scripts now pick up glob@13.0.0 from the root.

Confidence Score: 5/5

Safe to merge — the change is a minimal, targeted fix that removes a workspace declaration causing Docker build failures, with no functional code altered.

The root devDependencies already carry glob@13.0.0 and yaml@^2.8.1, so the scripts that previously relied on the workspace-scoped glob@11.1.0 continue to resolve correctly. The author validated all three affected check scripts and ran a local simulated Docker build successfully. No application code is touched.

No files require special attention; all three changed files (package.json, scripts/package.json, bun.lock) are straightforward configuration/lockfile updates.

Important Files Changed

Filename Overview
package.json Removes "scripts" from the workspaces array; glob and yaml dependencies used by scripts are already present in root devDependencies
scripts/package.json Deleted — workspace manifest is no longer needed since scripts/ is no longer a Bun workspace
bun.lock Removes the sim-doc-generator workspace entry and its scoped glob@11.1.0 dependency; root-level glob@13.0.0 takes over for script resolution

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["turbo prune sim --docker"] --> B["Pruned package.json\n(apps/sim only)"]
    B -->|"Before fix"| C["scripts/ listed in workspaces\nbut directory absent"]
    C --> D["bun install\n❌ Workspace not found 'scripts'"]
    B -->|"After fix"| E["scripts/ NOT in workspaces"]
    E --> F["bun install\n✅ 1856 packages installed"]
    G["Root devDependencies\nglob@13, yaml@^2.8"] --> F
    H["scripts/*.ts\n(run via bun run from repo root)"] --> G
Loading

Reviews (1): Last reviewed commit: "fix(docker): drop scripts/ from workspac..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit 28e60bf into staging May 7, 2026
9 of 10 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/fix-scripts-workspace-prune branch May 7, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant