fix(workday): correct SOAP service routing and reference types#4485
fix(workday): correct SOAP service routing and reference types#4485waleedlatif1 merged 2 commits intostagingfrom
Conversation
- create-prehire: route Put_Applicant to Recruiting service (was Staffing, where the operation does not exist) - assign-onboarding: use WID for Action_Event_Reference (was Background_Check_ID, wrong identifier domain for hire events) - update-worker block: rewrite labels and wand prompt to match Change_Personal_Information demographic-only scope (prior prompt instructed LLM to emit businessTitle/primaryWorkEmail which the SOAP op rejects) - enrich opaque JSON output descriptions on worker, workers, organizations, compensationPlans
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Updates the Workday block UI/LLM guidance for Reviewed by Cursor Bugbot for commit 27a9f53. Configure here. |
Greptile SummaryThis PR corrects three concrete SOAP integration bugs in the Workday integration: wrong service endpoint for
Confidence Score: 5/5Safe to merge — all three changes are targeted corrections to wrong SOAP service names and ID types, with no new logic paths introduced. Each fix addresses a concrete, previously broken call: Put_Applicant routed to the wrong service (guaranteed 500), Action_Event_Reference using a mismatched ID domain (guaranteed SOAP fault), and a wand prompt producing fields the target operation rejects. The corrections are minimal and well-scoped, the operation IDs and surrounding logic are unchanged, and there are no new code paths or state changes that could introduce regressions. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix(workday): correct Date_of_Birth casi..." | Re-trigger Greptile |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 27a9f53. Configure here.
Summary
Type of Change
Testing
Validated each route against Workday Web Services v45 docs (Recruiting/Put_Applicant, HR/Put_Onboarding_Plan_Assignment, HR/Change_Personal_Information, Staffing/Hire_Employee, Staffing/Terminate_Employee). TypeScript compiles clean; lint passes.
Checklist