chore(deps): audit and clean up dependencies#4531
Conversation
- Remove unused: chalk, chart.js, dotenv, encoding, entities, thread-stream, uuid, @opentelemetry/exporter-jaeger, critters, marked, redis, soap - Replace soap with hand-rolled Workday SOAP client - Migrate marked to unified pipeline for inbox responses - Bump zustand v5, @react-email/* - Align all @aws-sdk/* to 3.1032.0 - Move type-only deps to devDependencies - Remove duplicate drizzle-orm/postgres overrides
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryHigh Risk Overview Updates Workday API routes to use the new coercion helpers. Switches inbox email HTML rendering from Cleans up and aligns dependencies/config. Removes several unused packages (including Reviewed by Cursor Bugbot for commit 5d8814e. Configure here. |
Greptile SummaryThis PR is a large dependency audit and cleanup: it removes unused packages (
Confidence Score: 4/5The SOAP rewrite and markdown migration are well-implemented; the main outstanding risk is the removal of pino/thread-stream from serverExternalPackages, which was already flagged in a prior review and remains unresolved in this diff. The hand-rolled XML parser is purpose-built and XXE-safe, and the response-mapping helpers correctly handle string-typed values from the new parser. The remark/rehype migration is equivalent to the old marked pipeline with the same XSS guards intact. The unresolved serverExternalPackages removal for pino and thread-stream is the one item that could cause a silent runtime regression in the standalone/docker build when trigger.dev activity is invoked. apps/sim/next.config.ts — the removal of pino/pino-pretty/thread-stream from serverExternalPackages warrants verification against the Docker/standalone build with trigger.dev active. Important Files Changed
Reviews (3): Last reviewed commit: "fix(workday): coerce compensation amount..." | Re-trigger Greptile |
- XML parser returns leaf text as strings; `!"false"` evaluated to `false`, causing all organizations to report `isActive: false` - Add parseSoapBoolean and parseSoapNumber helpers and apply at consumer sites (Inactive, Total_Results) - Drop unused service/soapAction fields from WD_OPERATIONS map
|
@greptile |
|
@cursor review |
- get-compensation returned Amount/Per_Unit_Amount/Individual_Target_Amount as strings (XML leaf text), violating the tool's number contract - Coerce via parseSoapNumber and widen plan type to number | string - Add defensive Date branch in marshal() so Date inputs serialize as ISO 8601 instead of String(date)
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a25b149. Configure here.
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5d8814e. Configure here.
Summary
Type of Change
Testing
Tested manually — type-check passes.
Checklist