feat(tables): pinned columns by waleedlatif1 · Pull Request #4770 · simstudioai/sim

waleedlatif1 · 2026-05-28T16:33:11Z

Summary

Add column pinning (pin to left) for the Tables grid — inspired by Clay/Airtable
Frozen columns use position: sticky with computed left offsets stacked after the checkbox column
Workflow output columns freeze/unfreeze as a group
Visual separator (box-shadow) on the rightmost frozen column in both header and data rows
Freeze state persists to TableMetadata via updateMetadataMutation; seeded from metadata on load
Added frozenColumns?: string[] to TableMetadata type and tableMetadataSchema

Type of Change

New feature

Testing

Tested manually

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-05-28T16:33:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		May 29, 2026 12:42am

cursor · 2026-05-28T16:33:21Z

PR Summary

Medium Risk
Touches core grid layout, column order invariants, metadata persistence, and undo paths; mistakes could mis-order columns or break sticky scrolling, but scope is UI/state with no auth or data-model changes.

Overview
Adds left pin (freeze) columns to the workspace table grid so key columns stay visible while scrolling horizontally.

Users can Pin / Unpin column from the column header and workflow-group context menus (new Pin / PinOff icons). Workflow output columns pin and unpin as a group. Pinned headers and body cells use position: sticky with computed left offsets after the checkbox column, plus a separator shadow on the rightmost pinned column.

Pin state is stored in TableMetadata.pinnedColumns, loaded on first metadata seed, and kept in sync on rename, delete, and metadata updates. Column order is re-sorted so pinned columns stay at the front; drag-reorder is limited to the same pinned/unpinned zone, with a safety re-sort on drop. Undo/redo restores pinned columns on column create/delete/reorder. Horizontal scroll-to-selection respects the full pinned edge instead of only the row-number gutter.

Also removes the header menu’s change column type handler (type changes remain via Edit column / sidebar) and switches the header chevron to the shared emcn icon set.

^{Reviewed by Cursor Bugbot for commit 3dbeeff. Bugbot is set up for automated code reviews on this repo. Configure here.}

greptile-apps · 2026-05-28T16:39:20Z

Greptile Summary

This PR adds left-side column pinning to the Tables grid, inspired by Clay/Airtable. Pinned columns use position: sticky with computed left offsets, workflow-output columns pin/unpin as a group, the pinned zone is enforced as a strict left-side invariant (pinned columns are always sorted to the front), and state persists to TableMetadata.pinnedColumns via the existing metadata mutation.

Sticky layout: pinnedOffsets (a Map<key, px>) is derived lazily via a useMemo keyed on a pinnedWidthsKey fingerprint so that resizing an unpinned column does not recreate the Map or re-render every DataRow.
Drag-zone enforcement: handleColumnDragOver and handleScrollDragOver both gate cross-zone drops (pinned ↔ unpinned), with a belt-and-suspenders re-sort in the drop handler.
Undo/redo integration: useTableUndo gains getPinnedColumns / onPinnedColumnsChange refs; create-column undo, delete-column undo/redo, and reorder-columns undo/redo all correctly handle live frozen state rather than stale snapshots.

Confidence Score: 5/5

Safe to merge — the pinning feature is well-contained, all edge cases in undo/redo are handled, and no regressions to existing column operations were found.

The sticky-offset computation is correctly guarded against stale widths via the pinnedWidthsKey fingerprint, the pinned-at-front invariant is enforced in both the drag handler and the undo/redo reorder path, and the metadata persistence mirrors existing patterns. The previously flagged undo issues for delete-column and reorder-columns have been addressed in this PR. No new correctness issues were found.

No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx	Core pinning logic: adds pinnedColumns state, handlePinToggle, frozenOffsets memos, drag-zone enforcement, scroll-to-reveal updates, and metadata persistence — all well-reasoned
apps/sim/hooks/use-table-undo.ts	Adds getPinnedColumns/onPinnedColumnsChange refs, wires pinned-column cleanup into create-column undo, delete-column undo/redo restore paths, and re-sorts reorder-columns snapshots to maintain pinned-at-front invariant
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/headers/workflow-group-meta-cell.tsx	Adds isPinned/onPinToggle/stickyLeft/isLastPinned props to WorkflowGroupMetaCell and ColumnOptionsMenu; adds Pin/Unpin dropdown item; removes useCallback from handlers
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/headers/column-header-menu.tsx	Adds pin props and sticky CSS; removes now-unused onChangeType prop; ChevronDown import migrated to internal icon library
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/data-row.tsx	Adds pinnedOffsets/lastPinnedColKey props; applies sticky positioning and separator shadow per-cell; equality guard updated for memo

_{Reviews (9): Last reviewed commit: "fix(tables): re-sort reorder-columns und..." | Re-trigger Greptile}

…e dead handleChangeType

waleedlatif1 · 2026-05-28T17:01:49Z

@greptile

waleedlatif1 · 2026-05-28T17:01:53Z

@cursor review

waleedlatif1 · 2026-05-28T17:36:41Z

@greptile

waleedlatif1 · 2026-05-28T17:36:44Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 6d19730. Configure here.}

waleedlatif1 · 2026-05-28T17:53:16Z

@greptile

waleedlatif1 · 2026-05-28T17:53:19Z

@cursor review

waleedlatif1 · 2026-05-28T18:08:24Z

@greptile

waleedlatif1 · 2026-05-28T18:08:28Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 6526129. Configure here.}

…le snapshot

waleedlatif1 · 2026-05-28T18:26:58Z

@greptile

waleedlatif1 · 2026-05-28T18:27:03Z

@cursor review

waleedlatif1

Fixed in 8b40c46. The create-column undo branch now reads current frozen state via getFrozenColumnsRef.current?.(), filters out the undone column name, calls onFrozenColumnsChangeRef.current?.(newFrozen), and batches frozenColumns into the same updateMetadataMutation call alongside columnWidths — consistent with how delete-column redo cleans up frozen state.

waleedlatif1 · 2026-05-28T18:47:52Z

@cursor review

waleedlatif1 · 2026-05-28T18:47:55Z

@greptile

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 8b40c46. Configure here.}

…writing

…umn action

waleedlatif1 · 2026-05-28T19:21:51Z

@greptile

waleedlatif1 · 2026-05-28T19:21:56Z

@cursor review

…mn was not frozen

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 641c031. Configure here.}

- rename frozenColumns → pinnedColumns across types, contract, undo actions, grid state/refs/props, and dropdown labels - add Pin / PinOff emcn icons; use them in the column menu in place of Lock / Unlock - pinned body cells render at z-[6], above the cell selection border (z-[5]), so the blue selection border can't draw on top of the sticky-left zone - restrict column drag-reorder to within the pinned or unpinned zone in both handleColumnDragOver and handleScrollDragOver; cross-zone drop indicators are suppressed - on unpin, slide the column to the first unpinned slot so the sticky zone stays contiguous; consolidates pin and unpin into one branch that always re-enforces pinned-at-front Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

TheodoreSpeaks · 2026-05-28T22:37:21Z

@greptile review

- collapse two onPinToggle JSX props that biome wanted on a single line - drop a WHAT comment in handleScrollDragOver; tighten the why-comments in handlePinToggle, handleColumnDragOver, and handleColumnDragEnd so they describe the invariant being protected instead of narrating the recent change Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 23b4466. Configure here.}

If the user reordered, then pinned a column, then undid the reorder, the restored snapshot could leave a currently-pinned column in the middle of columnOrder. pinnedOffsets walks displayColumns left→right and assigns sticky `left` from checkboxColWidth — a pinned column in the middle gets a sticky offset as if it were at the front, causing it to jump over its left neighbors on horizontal scroll. Re-sort the restored order with pinned entries pulled to the front before applying. Mirrors the belt-and-suspenders re-sort in handleColumnDragEnd. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

TheodoreSpeaks · 2026-05-29T01:21:02Z

@greptile review

feat(tables): freeze columns

7c67bcb

cursor Bot reviewed May 28, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

fix(tables): sticky meta-header row for frozen workflow groups, remov…

08e4ff7

…e dead handleChangeType

vercel Bot temporarily deployed to Preview May 28, 2026 17:00 Inactive

cursor Bot reviewed May 28, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx Outdated

fix(tables): scope frozenOffsets dep to frozen column widths only

6d19730

vercel Bot temporarily deployed to Preview May 28, 2026 17:35 Inactive

fix(tables): restore frozenColumns on delete-column undo/redo

065dc56

cursor Bot reviewed May 28, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview May 28, 2026 17:50 Inactive

cursor Bot reviewed May 28, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx Outdated

fix(tables): restore useMemo for isAllRowsSelected (O(n) computation)

6526129

vercel Bot temporarily deployed to Preview May 28, 2026 18:06 Inactive

greptile-apps Bot reviewed May 28, 2026

View reviewed changes

Comment thread apps/sim/hooks/use-table-undo.ts Outdated

cursor Bot reviewed May 28, 2026

View reviewed changes

fix(tables): use current frozenColumns on delete-column redo, not sta…

b37a049

…le snapshot

vercel Bot temporarily deployed to Preview May 28, 2026 18:26 Inactive

fix(tables): clean up frozenColumns on create-column undo

8b40c46

vercel Bot temporarily deployed to Preview May 28, 2026 18:45 Inactive

waleedlatif1 commented May 28, 2026

View reviewed changes

greptile-apps Bot reviewed May 28, 2026

View reviewed changes

Comment thread apps/sim/hooks/use-table-undo.ts Outdated

cursor Bot reviewed May 28, 2026

View reviewed changes

fix(tables): merge frozen state on delete-column undo instead of over…

9236321

…writing

vercel Bot temporarily deployed to Preview May 28, 2026 19:12 Inactive

fix(tables): add previousFrozenColumns to test fixture for delete-col…

641c031

…umn action

vercel Bot temporarily deployed to Preview May 28, 2026 19:21 Inactive

fix(tables): skip frozen state update on delete-column redo when colu…

c9b848e

…mn was not frozen

vercel Bot temporarily deployed to Preview May 28, 2026 19:26 Inactive

cursor Bot reviewed May 28, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview May 28, 2026 22:37 Inactive

cursor Bot reviewed May 28, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

vercel Bot temporarily deployed to Preview May 28, 2026 23:50 Inactive

cursor Bot reviewed May 28, 2026

View reviewed changes

Comment thread apps/sim/hooks/use-table-undo.ts

vercel Bot temporarily deployed to Preview May 29, 2026 00:42 Inactive

TheodoreSpeaks changed the title ~~feat(tables): freeze columns~~ feat(tables): pinned columns May 29, 2026

TheodoreSpeaks merged commit 6598927 into staging May 29, 2026
14 checks passed

TheodoreSpeaks deleted the fix/frozen branch May 29, 2026 17:56

waleedlatif1 mentioned this pull request May 29, 2026

v0.6.96: pinned table columns, sequence number in copilot messages, tables UI improvements, new slack scopes, model-level denylists, object storage tracespans #4798

Merged

Conversation

waleedlatif1 commented May 28, 2026 • edited by TheodoreSpeaks Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

waleedlatif1 left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

waleedlatif1 commented May 28, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

TheodoreSpeaks commented May 28, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheodoreSpeaks commented May 29, 2026

Uh oh!

Uh oh!

waleedlatif1 commented May 28, 2026 •

edited by TheodoreSpeaks

Loading

vercel Bot commented May 28, 2026 •

edited

Loading

cursor Bot commented May 28, 2026 •

edited

Loading

greptile-apps Bot commented May 28, 2026 •

edited

Loading