feat(slack): request channels:manage and groups:write for conversation ops#4792
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Custom bot tokens are unchanged. Existing Slack OAuth connections must reconnect to grant the new scopes. Reviewed by Cursor Bugbot for commit 5a257ac. Configure here. |
Greptile SummaryThis PR adds two missing Slack OAuth scopes (
Confidence Score: 5/5Safe to merge — a two-line additive change to a static scope list with no logic modifications. The change is a minimal, targeted fix: two OAuth scope strings are inserted into a static array. The affected tools already include No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant SimBot as Sim Bot (OAuth)
participant SlackAPI as Slack API
User->>SimBot: Trigger "Create Conversation" / "Invite to Conversation"
SimBot->>SlackAPI: POST conversations.create or conversations.invite (Bearer OAuth token)
alt Before this PR (missing scopes)
SlackAPI-->>SimBot: "{ ok: false, error: "missing_scope" }"
SimBot-->>User: Error: Missing required permissions
else After this PR (channels:manage + groups:write added)
SlackAPI-->>SimBot: "{ ok: true, channel: {...} }"
SimBot-->>User: Success
end
Reviews (1): Last reviewed commit: "feat(slack): request channels:manage and..." | Re-trigger Greptile |
Summary
channels:manageandgroups:writeto the Slack OAuth scope set so the "Create Conversation" and "Invite to Conversation" operations work with the hosted (Sim Bot) OAuth credential — these callconversations.create/conversations.invite, which require those scopes for public and private channels respectivelymissing_scopeon OAuth credentials (custom bot tokens are unaffected; they bring their own scopes)reactions:readwas intentionally NOT added sincereactions.getis only used by the custom-bot trigger path, never the OAuth tokenType of Change
Testing
Tested manually;
lintpasses. Note: existing Slack OAuth connections must reconnect to pick up the new scopes (the credential selector surfaces the reconnect prompt).Checklist