chore(auth): remove deprecated OAuth MCP provider plugin and backing tables#4847
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Deleted surfaces: Proxy/tests: CORS no longer special-cases DB: Migration Unchanged: Integration OAuth via Reviewed by Cursor Bugbot for commit 9b834bf. Configure here. |
Greptile SummaryThis PR removes the deprecated
Confidence Score: 4/5Safe to merge — this is a well-scoped dead-code removal with one minor leftover in the proxy that has no functional impact. The removal is thorough and consistent across all layers: auth plugins, routes, contracts, schema, migration, and mocks. The only missed cleanup is the isMcpOauthDiscoveryEndpoint exemption in proxy.ts that still references the now-deleted /.well-known/ paths; since those routes 404 regardless, it has no effect in practice. The migration correctly drops all four tables with CASCADE and the dependency ordering is valid. apps/sim/proxy.ts — the isMcpOauthDiscoveryEndpoint variable was not removed alongside the CORS rule cleanup. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph REMOVED["Removed (this PR)"]
A["/.well-known/oauth-authorization-server"] --> D["oauth-discovery.ts"]
B["/.well-known/oauth-protected-resource"] --> D
C["/oauth/consent page"] --> E["oidcProvider plugin"]
F["/api/auth/oauth2/authorize-params"] --> G["cimd.ts"]
E --> H["jwt plugin"]
H --> I[("jwks table")]
E --> J[("oauth_application table")]
E --> K[("oauth_access_token table")]
E --> L[("oauth_consent table")]
G --> J
end
subgraph KEPT["Kept intact"]
M["genericOAuth integrations"]
N["oneTimeToken plugin"]
O["SSO / organization / admin"]
P["/api/mcp/copilot/.well-known/..."]
Q["lib/mcp/oauth (client)"]
R["/api/mcp/copilot 410 tombstone"]
end
style REMOVED fill:#fee2e2,stroke:#ef4444
style KEPT fill:#dcfce7,stroke:#22c55e
|
Summary
Kept intact: all integration OAuth (`genericOAuth`), `oneTimeToken`, `admin`, `organization`, `sso`, `stripe`, the MCP client OAuth (`lib/mcp/oauth`), and the separate Copilot-MCP 410 tombstones.
Type of Change
Testing
Tested manually — `bunx biome check` clean across all changed files; `bun run check:api-validation` and `:strict` both pass (761 routes); migration regenerated cleanly against the staging schema snapshot (single file, 4 `DROP TABLE`).
Checklist