feat(workspaces): gate workspace forking behind runtime workspace-forking feature flag#5280
Conversation
…king feature flag
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview
Unit tests cover the fallback secret path and AppConfig org/user targeting for the new flag. Reviewed by Cursor Bugbot for commit 8323162. Configure here. |
Greptile SummaryThis PR adds a runtime gate for workspace forking. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix(workspaces): scope workspace-forking..." | Re-trigger Greptile |
…s to preserve self-hosted gate
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8323162. Configure here.
Summary
workspace-forkingfeature flag (AppConfig-backed on Sim Cloud, secret fallback off-AppConfig) so we can dark-launch workspace forking to specific orgs/users/admins without a redeploy.assertForkingEnabledchoke point (fork/promote/rollback) on the flag with{ userId, orgId }context; an off/absent flag 404s so a newer image never silently exposes forking. The Enterprise-plan entitlement still applies on top on Sim Cloud.FORKING_ENABLEDsecret as the flag's fallback — no new env var, and self-hosted behavior is unchanged.Notes
useForkingAvailable) can't see the flag (there is no client AppConfig), so during a dark-launch an Enterprise org may briefly see fork UI that 404s until the flag is enabled. This is the standard dark-launch tradeoff; the server gate remains the security boundary.workspace-forkingto the hostedfeature-flagsAppConfig document and run asim-<env>-fastdeployment to roll out.Type of Change
Testing
feature-flags.test.tspasses (15/15), biome clean.Checklist