improvement(permissions): fixed permissions and variables access patterns

[waleedlatif1]

Description

fixed permissions and variables access patterns, we were still maintaining the old system to fetch workflow permissions via workspace member, but now we actually have permissions

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Performance improvement

How Has This Been Tested?

Tested to ensure permissions system still works properly.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• All tests pass locally and in CI (bun run test)
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• I have updated version numbers as needed (if needed)
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

• My changes do not introduce any new security vulnerabilities
• I have considered the security implications of my changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sim	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 25, 2025 3:22am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Skipped (Inspect)			Jun 25, 2025 3:22am

[greptile-apps]

PR Summary

Major refactor of the permissions system, moving from workspace-member based permissions to a dedicated permissions system for workflows and variables, with improved caching and test coverage.

• Implemented new permission utilities in apps/sim/app/api/workflows/[id]/route.ts with getUserEntityPermissions and hasAdminPermission for granular access control
• Optimized workflow variable handling in apps/sim/app/w/[id]/workflow.tsx to prevent unnecessary resets during workflow switching
• Added comprehensive test coverage in apps/sim/app/api/workflows/[id]/variables/route.test.ts for the new permissions system
• Reduced cache time from 60s to 30s and implemented content-based ETags in variables API for better performance
• Removed deprecated test-socket-integration.html as part of cleanup

_{7 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile}

[delve-auditor]

✅ No security or compliance issues detected. Reviewed everything up to 7cf46e7.

Security Overview

• 🔎 Scanned files: 7 changed file(s)

Detected Code Changes

Change Type	Relevant files
Enhancement	► route.test.ts     Add tests for workflow and workflow variables APIs ► route.ts     Optimize permissions handling and caching for variables ► variables.tsx     Improve variable loading logic ► workflow.tsx     Optimize variables reset handling
Other	► test-socket-integration.html     Remove test file

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.