fix(ui): surface silent validation and rejection errors across editors and modals#5394
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Knowledge chunk editor shows toasts for empty content and the 10k character cap (replacing the previous toast on retry). Table inline editors toast and use error styling for invalid dates, numbers, and JSON; blur on bad values cancels the edit instead of saving Version description modal adds a ChipModalField error with current vs max length when over 50k characters. Create workspace keeps the modal open on API failure: the hook re-throws after logging, and the modal maps the error into ChipModalError (cleared when the name changes or the dialog reopens). Reviewed by Cursor Bugbot for commit bd9824c. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummarySurfaces previously silent validation and API errors across six distinct UI surfaces — chunk editor, version description modal, table inline/expanded-cell editors, chat deploy identifier field, create-workspace modal, and profile name editing — replacing silent reverts, disabled buttons, or null cell overwrites with inline error messages and toasts.
Confidence Score: 5/5Safe to merge — all changes are additive error-surfacing paths with no alterations to the underlying save logic. Every change is narrowly scoped to surfacing an existing silent failure: no data paths are altered, no new async flows introduced, and the deduplication guards are correctly wired to their respective closure dependencies. No files require special attention. Important Files Changed
Reviews (4): Last reviewed commit: "fix(tables): reject invalid date/number ..." | Re-trigger Greptile |
…-validation # Conflicts: # apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/inline-editors.tsx
|
@greptile review |
|
@greptile review |
…pe invalid-input toasts
|
@greptile review |
…g the previous toast
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4476fd3. Configure here.

Summary
ChipModalErrorand keep the modal open instead of closing silentlyType of Change
Testing
Tested manually;
bun run lint,tsc --noEmit, andcheck:api-validation:strictpassChecklist