Skip to content

fix(404): use ChipLink for return-home CTA on root not-found page#5424

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/error-page-cta-chip
Jul 5, 2026
Merged

fix(404): use ChipLink for return-home CTA on root not-found page#5424
waleedlatif1 merged 1 commit into
stagingfrom
fix/error-page-cta-chip

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Root 404 page (app/not-found.tsx) hand-rolled a <Link> with raw Tailwind classes to mimic a primary chip button
  • Replaced with ChipLink variant='primary' from @sim/emcn, matching the pattern already used by the sibling landing not-found pages (models, integrations, comparison)
  • Note: this standardizes the CTA to the platform's canonical chip geometry (30px height, rounded-lg, px-2), which is more compact than the removed bespoke inline styles (40px height, rounded-[5px], px-5). This is an intentional trade-off — matching the already-established convention on every sibling not-found page rather than preserving a one-off custom size

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Matches the emcn ChipLink pattern already used by sibling landing not-found pages instead of a hand-rolled Link with raw Tailwind classes.
@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 5, 2026 1:59am

Request Review

@cursor

cursor Bot commented Jul 5, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single-page UI swap on a non-critical 404 screen; no auth, data, or routing logic changes.

Overview
The root 404 page (app/not-found.tsx) swaps a hand-styled next/link “Return home” button for ChipLink variant='primary' from @sim/emcn, with the same mt-3 spacing.

That aligns the CTA with other landing not-found pages (e.g. comparison, integrations) and drops one-off Tailwind (taller button, custom radius/padding) in favor of the shared chip styling.

Reviewed by Cursor Bugbot for commit 00901fd. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Replaces a hand-rolled <Link> with raw Tailwind classes in app/not-found.tsx with the canonical ChipLink variant='primary' from @sim/emcn, matching the identical pattern already used on the sibling landing not-found pages (models, integrations, comparison).

  • Component swap: <Link className='mt-3 inline-flex h-[40px] …'><ChipLink variant='primary' href='/' className='mt-3'>, removing the duplicate inline chrome styles.
  • Import cleanup: next/link import removed; @sim/emcn added — consistent with every other not-found page in the app.

Confidence Score: 5/5

Safe to merge — one file changed, the swap is mechanically identical to what the three sibling not-found pages already ship.

The change is a direct component substitution with no logic, no state, and no data flow. ChipLink variant='primary' is a well-established, already-tested pattern in this codebase, and mt-3 is the only className passed — within the layout-only scope that chip chrome allows. No edge cases or regressions to worry about.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/not-found.tsx Swaps bespoke with ChipLink variant='primary' from @sim/emcn; usage and prop set match the three sibling not-found pages exactly.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["app/not-found.tsx\n(root 404)"] -->|"before: hand-rolled Link\nw/ inline Tailwind chrome"| B["next/link Link\nh-40px·rounded-5px·px-5"]
    A -->|"after: canonical component"| C["ChipLink variant='primary'\n(@sim/emcn)"]
    C --- D["chip-chrome.ts\n(h-30px·rounded-lg·px-2)"]
    E["(landing)/models/not-found.tsx"] -->|same pattern| C
    F["(landing)/integrations/not-found.tsx"] -->|same pattern| C
    G["(landing)/comparison/not-found.tsx"] -->|same pattern| C
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["app/not-found.tsx\n(root 404)"] -->|"before: hand-rolled Link\nw/ inline Tailwind chrome"| B["next/link Link\nh-40px·rounded-5px·px-5"]
    A -->|"after: canonical component"| C["ChipLink variant='primary'\n(@sim/emcn)"]
    C --- D["chip-chrome.ts\n(h-30px·rounded-lg·px-2)"]
    E["(landing)/models/not-found.tsx"] -->|same pattern| C
    F["(landing)/integrations/not-found.tsx"] -->|same pattern| C
    G["(landing)/comparison/not-found.tsx"] -->|same pattern| C
Loading

Reviews (2): Last reviewed commit: "fix(404): use ChipLink for return-home C..." | Re-trigger Greptile

Comment thread apps/sim/app/not-found.tsx
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 00901fd. Configure here.

@waleedlatif1 waleedlatif1 merged commit 82eb6dc into staging Jul 5, 2026
19 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/error-page-cta-chip branch July 5, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant