Skip to content

fix(compare): render two already-populated fact rows missing from the table#5425

Merged
waleedlatif1 merged 1 commit into
stagingfrom
worktree-add-datatables-row
Jul 5, 2026
Merged

fix(compare): render two already-populated fact rows missing from the table#5425
waleedlatif1 merged 1 commit into
stagingfrom
worktree-add-datatables-row

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • dataTables and richTextEditor are required fact fields already researched and filled in for Sim and every competitor, but neither key was ever added to the row list the comparison table actually renders.
  • Adds both as rows in the Platform section.

Type of Change

  • Bug fix

Testing

  • tsc --noEmit clean (confirms every profile already has both fields populated)
  • biome check clean

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…g from the table

dataTables and richTextEditor are required fact fields, already researched and
filled in for Sim and every competitor, but neither was ever added to the row
list the table actually renders.
@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 5, 2026 2:17am

Request Review

@cursor

cursor Bot commented Jul 5, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Landing-page display-only change to which fact rows are shown; no auth, data, or business-logic changes.

Overview
Fixes missing Platform rows on competitor comparison pages: dataTables (Native data tables) and richTextEditor (Rich-text document editor) were already defined and populated in every competitor profile, but they were omitted from COMPARISON_SECTIONS in comparison-sections.ts, so the table never rendered them.

Adds both keys to the Platform section row list (between native file storage and sub-workflows), so all comparison pages that use this canonical section config will surface the existing fact data.

Reviewed by Cursor Bugbot for commit a96f55d. Configure here.

@waleedlatif1 waleedlatif1 merged commit 85f80fa into staging Jul 5, 2026
13 checks passed
@greptile-apps

greptile-apps Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes the comparison table by adding two missing fact rows — dataTables and richTextEditor — to the Platform section. Both keys have been present in the ComparisonFacts type and populated in every competitor profile, but were never wired into the rendered row list.

  • Adds { key: 'dataTables', label: 'Native data tables' } and { key: 'richTextEditor', label: 'Rich-text document editor' } between nativeFileStorage and subWorkflows in COMPARISON_SECTIONS.
  • The defineSection<G> generic enforces key correctness against ComparisonFacts['platform'] at compile time, so this change is fully type-safe with no risk of a runtime key mismatch.

Confidence Score: 5/5

Safe to merge — the change is a two-line addition to a compile-time-validated config array with no runtime risk.

Both keys (dataTables, richTextEditor) are defined in ComparisonFacts['platform'] and the defineSection generic validates them at compile time, so a typo would fail the build. The rows are data-only; no rendering logic, business logic, or tests are affected.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/(landing)/comparison/comparison-sections.ts Adds dataTables and richTextEditor rows to the Platform section; both keys exist in ComparisonFacts['platform'] and are enforced by the defineSection generic, so the change is type-safe and complete.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[COMPARISON_SECTIONS] --> B[defineSection generic\nenforces key correctness]
    B --> C[Platform rows]
    C --> C1[builderType]
    C --> C2[...]
    C --> C3[nativeFileStorage]
    C --> C4["dataTables NEW"]
    C --> C5["richTextEditor NEW"]
    C --> C6[subWorkflows]
    B --> D[ComparisonFacts.platform\ntype definition]
    D --> D1[dataTables: Fact]
    D --> D2[richTextEditor: Fact]
    D1 -.->|compile-time checked| C4
    D2 -.->|compile-time checked| C5
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[COMPARISON_SECTIONS] --> B[defineSection generic\nenforces key correctness]
    B --> C[Platform rows]
    C --> C1[builderType]
    C --> C2[...]
    C --> C3[nativeFileStorage]
    C --> C4["dataTables NEW"]
    C --> C5["richTextEditor NEW"]
    C --> C6[subWorkflows]
    B --> D[ComparisonFacts.platform\ntype definition]
    D --> D1[dataTables: Fact]
    D --> D2[richTextEditor: Fact]
    D1 -.->|compile-time checked| C4
    D2 -.->|compile-time checked| C5
Loading

Reviews (1): Last reviewed commit: "fix(compare): render two already-populat..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 deleted the worktree-add-datatables-row branch July 5, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant