fix(autolayout): autolayout with sockets#543
Closed
icecrasher321 wants to merge 3 commits intorefactor/workspace-idfrom
Closed
fix(autolayout): autolayout with sockets#543icecrasher321 wants to merge 3 commits intorefactor/workspace-idfrom
icecrasher321 wants to merge 3 commits intorefactor/workspace-idfrom
Conversation
added 2 commits
June 25, 2025 10:28
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
✅ No security or compliance issues detected. Reviewed everything up to 318c05d. Security Overview
Detected Code Changes
Reply to this PR with |
Contributor
There was a problem hiding this comment.
PR Summary
Optimizes autolayout animation by deferring socket updates until completion to prevent performance issues in multi-tab scenarios.
- Added
onCompletecallback toapplyAutoLayoutSmoothinapps/sim/app/w/[id]/utils.tsto handle socket updates after animation finishes - Introduced batched position updates in
apps/sim/app/w/[id]/workflow.tsxto reduce network traffic during collaborative editing - Extracted orientation configuration into
getOrientationConfighelper function for better code organization - Implemented proper cleanup of animation states to prevent memory leaks and race conditions
2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
…to fix/autolayout
Collaborator
|
duplicate of #546 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do sockets update function only at the end of the autolayout rendering.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test autolayout with two tabs open
Checklist:
bun run test)Security Considerations:
Additional Information:
Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.