fix(userPresence): show avatars by user ID not socket conn id#550
Merged
icecrasher321 merged 1 commit intostagingfrom Jun 26, 2025
Merged
fix(userPresence): show avatars by user ID not socket conn id#550icecrasher321 merged 1 commit intostagingfrom
icecrasher321 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
PR Summary
Fixed user presence tracking to show unique avatars per user instead of per socket connection, preventing duplicate avatars when users have multiple tabs open.
- Modified
apps/sim/socket-server/rooms/manager.tsto track unique users by userId instead of socketId with new getUniqueUserCount() method - Updated
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-presence.tsto deduplicate users using Map and userId as key - Enhanced
apps/sim/contexts/socket-context.tsxto properly handle socket cleanup and prevent duplicate connections - Improved socket connection lifecycle in
apps/sim/socket-server/handlers/workflow.tswith separate tracking for unique users vs total connections
4 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
✅ No security or compliance issues detected. Reviewed everything up to fb40d25. Security Overview
Detected Code Changes
Reply to this PR with |
arenadeveloper02
pushed a commit
to arenadeveloper02/p2-sim
that referenced
this pull request
Sep 19, 2025
fix(userPresence): show avatars by user ID not socket conn id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If same user on multiple tabs then doesn't show avatar anymore.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:
bun run test)Security Considerations:
Additional Information:
Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.