Skip to content

fix(workspace url id bug): switch workspace bug #564

Merged
icecrasher321 merged 2 commits intostagingfrom
fix/switch-workspace-url-bug
Jun 27, 2025
Merged

fix(workspace url id bug): switch workspace bug #564
icecrasher321 merged 2 commits intostagingfrom
fix/switch-workspace-url-bug

Conversation

@icecrasher321
Copy link
Copy Markdown
Collaborator

Description

Need to fully switch workspace with correct workspace id before doing router.push

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Security enhancement
  • Performance improvement
  • Code refactoring (no functional changes)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

Additional Information:

Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 4:42am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jun 27, 2025 4:42am

@icecrasher321 icecrasher321 changed the base branch from main to staging June 27, 2025 03:29
@delve-auditor
Copy link
Copy Markdown

delve-auditor Bot commented Jun 27, 2025

No security or compliance issues detected. Reviewed everything up to 0979185.

Security Overview
  • 🔎 Scanned files: 6 changed file(s)
Detected Code Changes
Change Type Relevant files
Bug Fix ► route.ts
    Add ordering by creation date for workflow queries
► workspace-header.tsx
    Improve workspace switching logic to prevent race conditions
► sidebar.tsx
    Refine workflow loading states and sorting
► page.tsx
    Enhance workflow loading logic for workspace transitions
► store.ts
    Update workflow registry state management
► socket-context.tsx
    Remove redundant logging

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

… race conditions during workspace transitions
@vercel vercel Bot temporarily deployed to Preview – docs June 27, 2025 04:38 Inactive
@icecrasher321 icecrasher321 merged commit 0049644 into staging Jun 27, 2025
4 checks passed
icecrasher321 added a commit that referenced this pull request Jun 27, 2025
icecrasher321 added a commit that referenced this pull request Jun 27, 2025
@waleedlatif1 waleedlatif1 deleted the fix/switch-workspace-url-bug branch June 28, 2025 04:45
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
* fix switch workspace bug"

* fix(workspaces): resolve workflow selection ordering issue, eliminate race conditions during workspace transitions

---------

Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net>
Co-authored-by: Waleed Latif <walif6@gmail.com>
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants