ci: socket realtime image for hosting#565
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
PR Summary
Added new realtime Socket.IO server infrastructure with Docker configuration for hosting. This introduces a critical service component for real-time functionality across the platform.
- Added new matrix entry in
.github/workflows/build.ymlto buildghcr.io/simstudioai/realtimeimage - Created
docker/realtime.Dockerfilewith Bun runtime configuration for Socket.IO server on port 3002 - Modified
docker-compose.prod.ymlto integrate realtime service with proper health checks and dependencies - Note: Current implementation bundles entire app due to mono-repo structure, pending future optimization
4 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| # Installing with full context to prevent missing dependencies error | ||
| RUN bun install --omit dev --ignore-scripts |
There was a problem hiding this comment.
style: Second bun install is redundant since deps were already copied. Consider removing this step
|
✅ No security or compliance issues detected. Reviewed everything up to 841934c. Security Overview
Detected Code Changes
Reply to this PR with |
|
@adiologydev can we add any info to the README to let users know how to run the pkg. we also need to think about how we can modify the root package.json build command maybe like dev:full to run the socket server by default. not sure if there are best practices in place for sockets/external servers and how they should be ran |
Sure, will add additional information about it in the readme. It's not advisable in production to use concurrently. Also the way we build the app (standalone), we can't really package anything else together in that image. |
* feat: socket server for self/local deployment * ci: memory limit and redundant dependency install * chore: update readme, devcontainer, cli package * chore: add new dev scripts and update README for full development setup
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Note: The image is highly unoptimized because it's all packaged within the same app in our mono-repo, this will gradually become a lot more lightweight once we properly utilise the mono-repo.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Locally built and ran.
Checklist:
bun run test)Security Considerations:
Additional Information:
Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.