[HTML] fix dps plot crash with fewer than six points#11455
Merged
vituscze merged 1 commit intoMay 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11287.
DPS plot HTML generation could divide by zero when
dps_plot_points < 6.The row count was calculated with integer division before
std::ceil, so a plot with 5 points producedrows = 0, and the lateridx % rowscheck crashed during HTML report generation.This switches the calculation to integer ceiling division and keeps the minimum row count at 1.
Validation:
simc profiles/MID1/MID1_Priest_Shadow.simc iterations=1 threads=1 output=NUL html=NUL dps_plot_stat=crit dps_plot_points=5 dps_plot_iterations=1 cleanup_threads=1simc profiles/MID1/MID1_Priest_Shadow.simc iterations=1 threads=1 output=NUL html=NUL dps_plot_stat=crit dps_plot_points=1 dps_plot_iterations=1 cleanup_threads=1simc profiles/MID1/MID1_Priest_Shadow.simc iterations=1 threads=1 output=NUL html=NUL dps_plot_stat=crit dps_plot_iterations=1 cleanup_threads=1git diff --check