Skip to content

[HTML] fix dps plot crash with fewer than six points #11455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vituscze merged 1 commit into from
May 11, 2026
+1 −1
Merged

[HTML] fix dps plot crash with fewer than six points #11455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/report/report_html_player.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3244,7 +3244,7 @@ void print_html_player_plots( report::sc_html_stream& os, const player_t& p, con
auto gear_rating = scale_override >= 0 ? scale_override : p.composite_rating( util::stat_to_rating( i ) );

size_t count = plot_data.size();
size_t rows = as<size_t>( std::ceil( count / 6 ) );
size_t rows = count ? ( ( count + 5 ) / 6 ) : 1;

os.format(
R"(<table class="sc"><tr class="details"><td class="details"><h4>{}</h4></td></tr><tr class="details">)",
Expand Down
Loading