Expose the destination subprocess methods on .pipe()#1252
Merged
Conversation
The return value of `subprocess.pipe()` now forwards the destination subprocess' iteration (`Symbol.asyncIterator`, `.iterable()`), stream conversion (`.all`, `.readable()`) and IPC (`.sendMessage()`, `.getOneMessage()`, `.getEachMessage()`) methods, so the piped output can be consumed directly. `.writable()` and `.duplex()` are not forwarded, since they write to the destination's `stdin`, which is already piped from the source. Fixes #1211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return value of
subprocess.pipe()now forwards the destination subprocess' iteration (Symbol.asyncIterator,.iterable()), stream conversion (.all,.readable()) and IPC (.sendMessage(),.getOneMessage(),.getEachMessage()) methods, so the piped output can be consumed directly.writable()and.duplex()are not forwarded, since they write to the destination'sstdin, which is already piped from the source.Fixes #1211