Add react-native globals#337
Open
JasonWeinzierl wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#129 was previously rejected, but re-opening because it seems the policy of this repo has changed.
There is an existing package, but it has not been touched for years. https://github.com/react-native-community/eslint-plugin-react-native-globals
IntersectionObserverandIntersectionObserverEntrybecause they are currently marked as "Canary and Experimental only".requirebecause it's listed in theirglobals.d.tsdespite missing from the website: https://github.com/facebook/react-native/blob/main/packages/react-native/src/types/globals.d.ts#L13EventandEventTargetbecause theirglobals.d.tsassumes they exist.globals.d.tsthat are not publicly documented (e.g.HermesInternal); not sure what's the policy on adding those.falsefor everything. The previous package settruefor some likesetImmediatebut unless I'm missing something, that seems wrong.