Update tree-sitter-rust requirement from 0.23.2 to 0.24.0 - #5
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Update tree-sitter-rust requirement from 0.23.2 to 0.24.0#5dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Updates the requirements on [tree-sitter-rust](https://github.com/tree-sitter/tree-sitter-rust) to permit the latest version. - [Release notes](https://github.com/tree-sitter/tree-sitter-rust/releases) - [Commits](tree-sitter/tree-sitter-rust@v0.23.2...v0.24.0) --- updated-dependencies: - dependency-name: tree-sitter-rust dependency-version: 0.24.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
sinelaw
pushed a commit
that referenced
this pull request
Apr 4, 2026
Replace direct std::fs::metadata and std::process::Command usage in check_git_index_mtime / resolve_git_index with the proper traits: - resolve_git_index: uses ProcessSpawner (works over SSH for remote) - git index mtime check: uses FileSystem.metadata() in background thread alongside directory metadata checks (non-blocking) This follows CONTRIBUTING.md rules #4 and #5: never use std::fs or std::process::Command directly — use the FileSystem and ProcessSpawner traits so features work transparently on remote hosts. https://claude.ai/code/session_01VxhvsKhfDTK6PjBWUqWjvJ
sinelaw
pushed a commit
that referenced
this pull request
Apr 5, 2026
Replace direct std::fs::metadata and std::process::Command usage in check_git_index_mtime / resolve_git_index with the proper traits: - resolve_git_index: uses ProcessSpawner (works over SSH for remote) - git index mtime check: uses FileSystem.metadata() in background thread alongside directory metadata checks (non-blocking) This follows CONTRIBUTING.md rules #4 and #5: never use std::fs or std::process::Command directly — use the FileSystem and ProcessSpawner traits so features work transparently on remote hosts. https://claude.ai/code/session_01VxhvsKhfDTK6PjBWUqWjvJ
sinelaw
pushed a commit
that referenced
this pull request
Apr 26, 2026
Read plugin runtime, input dispatch, and render pipeline end-to-end to verify the design assumptions. Net effect on the API table: - #5 narrowed: expose existing OverlayManager::extend() fast-path as setNamespaceOverlays() instead of a generic batchDecorations wrapper — smaller change, same win. - #9 resolved: clearNamespace works as advertised at overlay.rs:319, ~1 µs for 100 overlays. - #12 added: single-global-mode constraint should be documented; plugins must save/restore prior mode themselves. No blockers found. getNextKey is essentially copy-paste from prompt's existing async pattern, wildcard binding is ~10 lines in keybindings resolution, render picks up plugin-written overlays in the same frame as the triggering keypress.
sinelaw
pushed a commit
that referenced
this pull request
Apr 26, 2026
Read plugin runtime, input dispatch, and render pipeline end-to-end to verify the design assumptions. Net effect on the API table: - #5 narrowed: expose existing OverlayManager::extend() fast-path as setNamespaceOverlays() instead of a generic batchDecorations wrapper — smaller change, same win. - #9 resolved: clearNamespace works as advertised at overlay.rs:319, ~1 µs for 100 overlays. - #12 added: single-global-mode constraint should be documented; plugins must save/restore prior mode themselves. No blockers found. getNextKey is essentially copy-paste from prompt's existing async pattern, wildcard binding is ~10 lines in keybindings resolution, render picks up plugin-written overlays in the same frame as the triggering keypress.
sinelaw
pushed a commit
that referenced
this pull request
Apr 26, 2026
Bug #5 from DEVCONTAINER_USABILITY_TEST_2026-04-26.md (L181, was Untested): the report observed that triggering Rebuild killed any open `*Terminal N*` tab. Wrote a harness reproducer to verify before fixing — the test passes on master, which means the in-editor `setAuthority` flow does NOT lose the terminal buffer. The observation in the original report is therefore caused by the production process restart that follows `setAuthority` (the editor execs a new binary; the PTY child of the old binary dies along with it). That's platform-level behavior the plugin can't intercept — fixing it requires either persisting terminal state across process restart or deferring the restart until after open PTYs close, both substantial work. Keeping the test as a regression guard for the in-process side: if a future change starts dropping terminal buffers from the buffer map during attach, this catches it.
sinelaw
pushed a commit
that referenced
this pull request
Apr 26, 2026
Bug #5 from DEVCONTAINER_USABILITY_TEST_2026-04-26.md (L181, was Untested): the report observed that triggering Rebuild killed any open `*Terminal N*` tab. Wrote a harness reproducer to verify before fixing — the test passes on master, which means the in-editor `setAuthority` flow does NOT lose the terminal buffer. The observation in the original report is therefore caused by the production process restart that follows `setAuthority` (the editor execs a new binary; the PTY child of the old binary dies along with it). That's platform-level behavior the plugin can't intercept — fixing it requires either persisting terminal state across process restart or deferring the restart until after open PTYs close, both substantial work. Keeping the test as a regression guard for the in-process side: if a future change starts dropping terminal buffers from the buffer map during attach, this catches it.
sinelaw
pushed a commit
that referenced
this pull request
Apr 27, 2026
Bug #5 from DEVCONTAINER_USABILITY_TEST_2026-04-26.md (L181, was Untested): the report observed that triggering Rebuild killed any open `*Terminal N*` tab. Wrote a harness reproducer to verify before fixing — the test passes on master, which means the in-editor `setAuthority` flow does NOT lose the terminal buffer. The observation in the original report is therefore caused by the production process restart that follows `setAuthority` (the editor execs a new binary; the PTY child of the old binary dies along with it). That's platform-level behavior the plugin can't intercept — fixing it requires either persisting terminal state across process restart or deferring the restart until after open PTYs close, both substantial work. Keeping the test as a regression guard for the in-process side: if a future change starts dropping terminal buffers from the buffer map during attach, this catches it.
sinelaw
pushed a commit
to PanAchy/fresh
that referenced
this pull request
May 5, 2026
Add optimized build profile for release artifacts. The `[profile.dist]` section existed but was empty (only `inherits = "release"`). This populates it with profile flags that reduce the binary from 62.4 MB to 40.7 MB (-34.7%), with xz compressed tarball going from ~12.4 MB to ~7.1 MB (-43%). Changes: strip=true, lto=fat, codegen-units=1, panic=abort, opt-level=z. The release workflow should use `--profile dist` instead of `--release`. Dev builds (`--release`) remain unchanged for fast iteration. Experiments: sinelaw#1-sinelaw#5, sinelaw#10 (autoresearch) Metric: binary_kb 62,386 → 40,726 (-34.7%) Decomposition: strip=true (-12%), panic=abort (-12%), lto=fat (-11%), opt-level=z (-3%). No single knob dominates — all four needed for full gain.
sinelaw
pushed a commit
that referenced
this pull request
May 5, 2026
Add optimized build profile for release artifacts. The `[profile.dist]` section existed but was empty (only `inherits = "release"`). This populates it with profile flags that reduce the binary from 62.4 MB to 40.7 MB (-34.7%), with xz compressed tarball going from ~12.4 MB to ~7.1 MB (-43%). Changes: strip=true, lto=fat, codegen-units=1, panic=abort, opt-level=z. The release workflow should use `--profile dist` instead of `--release`. Dev builds (`--release`) remain unchanged for fast iteration. Experiments: #1-#5, #10 (autoresearch) Metric: binary_kb 62,386 → 40,726 (-34.7%) Decomposition: strip=true (-12%), panic=abort (-12%), lto=fat (-11%), opt-level=z (-3%). No single knob dominates — all four needed for full gain.
sinelaw
pushed a commit
that referenced
this pull request
May 18, 2026
The settings UI rendered boolean toggles as either '[ ✓ ACTIVE ]' (12 columns, shouty caps) or '[ ]' (12 columns of empty space). The unchecked state was visually indistinguishable from an empty text input, and the shouty caps stood out from the rest of the form chrome. Switch to the '[v]' / '[ ]' convention already used by the host's plugin-widget Toggle renderer, making checkboxes recognisable at a glance and aligning the bespoke settings renderer with the rest of the editor's toggle styling. Addresses UX review issue #5 ("Real checkboxes") from docs/internal/settings-lsp-language-dialogs.md.
sinelaw
pushed a commit
that referenced
this pull request
May 19, 2026
The settings UI rendered boolean toggles as either '[ ✓ ACTIVE ]' (12 columns, shouty caps) or '[ ]' (12 columns of empty space). The unchecked state was visually indistinguishable from an empty text input, and the shouty caps stood out from the rest of the form chrome. Switch to the '[v]' / '[ ]' convention already used by the host's plugin-widget Toggle renderer, making checkboxes recognisable at a glance and aligning the bespoke settings renderer with the rest of the editor's toggle styling. Addresses UX review issue #5 ("Real checkboxes") from docs/internal/settings-lsp-language-dialogs.md.
sinelaw
pushed a commit
that referenced
this pull request
May 26, 2026
…advanced features Tested: TC-060-065 (command palette full coverage), TC-070-073 (settings/theme/keybinding), TC-081-085 (binary file, empty file, rapid keys, resize, 12+ tabs), Git Log (55-commit live preview), Macro recording (F5/F4 workflow), Bookmarks (palette + Alt+N), Markdown preview (ANSI bold/italic rendering), Review Diff, Live Grep (77 results streaming), Diagnostics Panel, Smart Home, Position History (Alt+Left), Auto-close brackets, Surround selection, Duplicate Line, path:line:col palette syntax. 0 new bugs confirmed. Updated knowledge base with Settings UI workflow, keybinding editor details, macro/bookmark workflows, and binary file handling notes. Run #5 plan: Large file (100MB+), Theme Editor visual, multi-language syntax highlighting, code folding, git blame, whitespace indicators. https://claude.ai/code/session_01Rz2F6gaZfVSf95zNVemcdx
sinelaw
pushed a commit
that referenced
this pull request
May 26, 2026
…2117) Tests completed (15+): - TC-080 PASSED: Large file (159MB), byte offsets, Scan Line Index, line 1M nav - TC-RUST/PYTHON/JS PASSED: Syntax highlighting confirmed for all 3 languages - TC-FOLD PASSED: Code folding (▸/▾), Toggle Fold, nav skips folded regions - TC-BLAME PASSED: Git Blame commit blocks, b/q navigation - TC-REVIEWDIFF PARTIAL: hunks/nav work; discard broken (BUG-007 / #2117) - TC-WHITESPACE PASSED: Trailing space ··· indicators confirmed - TC-ENCODING PASSED: Latin-1 / Windows-1252 auto-detected - TC-THEME-EDITOR PARTIAL: opens/shows colors; color editing workflow unclear - TC-MOVE-EXPLORER PASSED: "Move File Explorer to Other Side" (0.3.8) - TC-LIVE-DIFF PASSED: vs HEAD shows green + lines - TC-RULERS PASSED: ruler at col 80 shows tinted column - TC-ORCHESTRATOR PASSED: Orchestrator "Open" shows session selector - TC-WORKSPACE-TRUST PASSED: ⚠ dialog, T/K options, .envrc detected New confirmed bug filed: - BUG-007 / #2117: Review Diff discard hunk fails ("patch does not apply") State files updated: run_log.md, test_plan.md, confirmed_bugs.md, learning_db.md (lessons #19-#28), github_issues.md (+#2117 row) https://claude.ai/code/session_019RLSGvU9sjy8m4FKgJUcrF
sinelaw
pushed a commit
that referenced
this pull request
May 27, 2026
A mouse click on a session row fires `select` with the clicked item's key (not the list key "sessions"), so the handler ignored it. Accept the click by also matching the payload's `list_key`, so clicking a row selects + live-switches it (and the focus event re-arms the dock). Add e2e: "/"+filter+Enter-returns-to-list (#5/#6), Space multi-select (#4), and mouse-click-row-then-Space-checks-that-row (#3). Make the order-stability test deterministic (sibling project dirs under one parent so the project-path sort is fixed) — the earlier flake was random tempdir paths, not the dock.
sinelaw
pushed a commit
that referenced
this pull request
May 27, 2026
A mouse click on a session row fires `select` with the clicked item's key (not the list key "sessions"), so the handler ignored it. Accept the click by also matching the payload's `list_key`, so clicking a row selects + live-switches it (and the focus event re-arms the dock). Add e2e: "/"+filter+Enter-returns-to-list (#5/#6), Space multi-select (#4), and mouse-click-row-then-Space-checks-that-row (#3). Make the order-stability test deterministic (sibling project dirs under one parent so the project-path sort is fixed) — the earlier flake was random tempdir paths, not the dock.
sinelaw
pushed a commit
that referenced
this pull request
May 31, 2026
A mouse click on a session row fires `select` with the clicked item's key (not the list key "sessions"), so the handler ignored it. Accept the click by also matching the payload's `list_key`, so clicking a row selects + live-switches it (and the focus event re-arms the dock). Add e2e: "/"+filter+Enter-returns-to-list (#5/#6), Space multi-select (#4), and mouse-click-row-then-Space-checks-that-row (#3). Make the order-stability test deterministic (sibling project dirs under one parent so the project-path sort is fixed) — the earlier flake was random tempdir paths, not the dock.
Merged
7 tasks
sinelaw
pushed a commit
that referenced
this pull request
Jun 8, 2026
`maybeAutoActivate` defers entirely when a `devcontainer.json` is present and the authority is still local, so the devcontainer attach popup goes first. The defer was unconditional and one-way, though, with no signal back when the devcontainer prompt was dismissed — so a user who picked "Ignore (once)" or "Ignore (always in this folder)" was left with no env popup at all on the host, even though they were clearly staying local. The same dead-end hit the next-session case: when the user had persistently dismissed in a prior session, devcontainer silently skipped its own popup on the next open, and env-manager deferred to a prompt that never came. Fix by listening to the cross-plugin `action_popup_result` channel for the devcontainer attach popup's outcome: - Any non-attach outcome sets a session-only `devcontainerDismissedThisSession` flag and immediately re-runs `maybeAutoActivate`, which now bypasses the defer guard and lets the env popup surface in the same session. - `dismiss_always` is also persisted as `devcontainer-decline:<cwd>` in env-manager's own plugin global state. On the next open, the defer guard checks this observation up front; if present, env-manager proceeds straight to the env flow instead of waiting on a silently-skipped devcontainer popup. We can't read devcontainer's own `attach:<cwd>` global state directly because plugin global state is namespaced per plugin (fresh.d.ts:2700). The observation key is a parallel record of what env-manager needs to know — namespace-isolated by design — and it never disagrees with devcontainer's own record because both update on the same `action_popup_result` event. Verified interactively in tmux: open a folder with both `.envrc` and `.devcontainer/devcontainer.json`, devcontainer popup appears, dismiss it, env popup appears immediately. (Test plan scenario #5 in the trust+env+devcontainer doc — previously would have failed; now passes.) https://claude.ai/code/session_019Gm3tj2kLNoQXCTp5Am9EH
sinelaw
pushed a commit
that referenced
this pull request
Jun 8, 2026
`maybeAutoActivate` defers entirely when a `devcontainer.json` is present and the authority is still local, so the devcontainer attach popup goes first. The defer was unconditional and one-way, though, with no signal back when the devcontainer prompt was dismissed — so a user who picked "Ignore (once)" or "Ignore (always in this folder)" was left with no env popup at all on the host, even though they were clearly staying local. The same dead-end hit the next-session case: when the user had persistently dismissed in a prior session, devcontainer silently skipped its own popup on the next open, and env-manager deferred to a prompt that never came. Fix by listening to the cross-plugin `action_popup_result` channel for the devcontainer attach popup's outcome: - Any non-attach outcome sets a session-only `devcontainerDismissedThisSession` flag and immediately re-runs `maybeAutoActivate`, which now bypasses the defer guard and lets the env popup surface in the same session. - `dismiss_always` is also persisted as `devcontainer-decline:<cwd>` in env-manager's own plugin global state. On the next open, the defer guard checks this observation up front; if present, env-manager proceeds straight to the env flow instead of waiting on a silently-skipped devcontainer popup. We can't read devcontainer's own `attach:<cwd>` global state directly because plugin global state is namespaced per plugin (fresh.d.ts:2700). The observation key is a parallel record of what env-manager needs to know — namespace-isolated by design — and it never disagrees with devcontainer's own record because both update on the same `action_popup_result` event. Verified interactively in tmux: open a folder with both `.envrc` and `.devcontainer/devcontainer.json`, devcontainer popup appears, dismiss it, env popup appears immediately. (Test plan scenario #5 in the trust+env+devcontainer doc — previously would have failed; now passes.) https://claude.ai/code/session_019Gm3tj2kLNoQXCTp5Am9EH
sinelaw
pushed a commit
that referenced
this pull request
Jun 8, 2026
`maybeAutoActivate` defers entirely when a `devcontainer.json` is present and the authority is still local, so the devcontainer attach popup goes first. The defer was unconditional and one-way, though, with no signal back when the devcontainer prompt was dismissed — so a user who picked "Ignore (once)" or "Ignore (always in this folder)" was left with no env popup at all on the host, even though they were clearly staying local. The same dead-end hit the next-session case: when the user had persistently dismissed in a prior session, devcontainer silently skipped its own popup on the next open, and env-manager deferred to a prompt that never came. Fix by listening to the cross-plugin `action_popup_result` channel for the devcontainer attach popup's outcome: - Any non-attach outcome sets a session-only `devcontainerDismissedThisSession` flag and immediately re-runs `maybeAutoActivate`, which now bypasses the defer guard and lets the env popup surface in the same session. - `dismiss_always` is also persisted as `devcontainer-decline:<cwd>` in env-manager's own plugin global state. On the next open, the defer guard checks this observation up front; if present, env-manager proceeds straight to the env flow instead of waiting on a silently-skipped devcontainer popup. We can't read devcontainer's own `attach:<cwd>` global state directly because plugin global state is namespaced per plugin (fresh.d.ts:2700). The observation key is a parallel record of what env-manager needs to know — namespace-isolated by design — and it never disagrees with devcontainer's own record because both update on the same `action_popup_result` event. Verified interactively in tmux: open a folder with both `.envrc` and `.devcontainer/devcontainer.json`, devcontainer popup appears, dismiss it, env popup appears immediately. (Test plan scenario #5 in the trust+env+devcontainer doc — previously would have failed; now passes.) https://claude.ai/code/session_019Gm3tj2kLNoQXCTp5Am9EH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on tree-sitter-rust to permit the latest version.
Release notes
Sourced from tree-sitter-rust's releases.
Commits
18b05150.24.0a1f37e8Regenerate w/ latest ABI3d087c30.23.3377ca96add expr_2021 and pat_param to fragment_specifier (#266)5b8dd57parse async closures (#265)4bbd594add tuple_type to possible dynamic types (#257)e86119bparse impl types (abstract types) where the lifetime comes first (#258)bb08b6fadd parsing support foruse ::*syntax (#261)5edb201fix where clauses in type aliases and allow empty where clauses (#259)5ebbba1fix shebang parsing (#260)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)