docs: correct the unknown-command exit code in the release checklist - #93
Merged
Merged
Conversation
0.11.0 made an unknown command exit 2 (usage) with a did-you-mean suggestion, rather than 1 plus a full help dump. The checklist still told the releaser to expect 1, so walking it for 0.12.0 read as a failed gate on correct behaviour.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while walking the checklist for 0.12.0.
docs/release-checklist.md§2 tells the releaser thatbogus-cmdshould exit1. Since 0.11.0 it exits2— the usage code — with a did-you-mean suggestion instead of a full help dump. That was a deliberate change ("unknown command is2(usage) with a did-you-mean suggestion instead of1+ a full help dump", CHANGELOG 0.11.0), so the code is right and the doc lagged.Walking the checklist for a release therefore reads as a failed gate on correct behaviour. One line.