rust: sync the bundled C sources with src/ (odbc_delegate.c); CI checks the copy - #78
Merged
Conversation
…ks the copy The delegation probe (#74) changed src/odbc_delegate.c without running rust/sync-csrc.sh, so the crate's bundled copy under rust/csrc still had the 0.1.0 delegation code. The Release workflow's crate job caught it (csrc_in_sync) and the v0.1.1 draft release has no crate. This copies the file over and adds a diff of src/ against rust/csrc/src to CI's version job, so the mismatch fails on the pull request instead of on the tag. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YG6wFApZpg2xe61EmKhaSZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.1.1 Release run failed in the crate job:
rust/csrc/src/odbc_delegate.cis out of date. #74 changedsrc/odbc_delegate.cwithout runningrust/sync-csrc.sh, and CI does not run the crate'scsrc_in_synctest, so it surfaced only after the tag.rust/sync-csrc.shrun;diff -rq src rust/csrc/srcis clean.Release consequence: the
v0.1.1tag points at a commit whose crate would ship the old delegation code. After this merges the plan is to delete the draft release and thev0.1.1tag (nothing has been published from either;go/v0.1.1is unaffected and stays), re-tagv0.1.1on the merge commit, and let the Release workflow run again.🤖 Generated with Claude Code
https://claude.ai/code/session_01YG6wFApZpg2xe61EmKhaSZ