Merged
Conversation
Fix property annotation.
Replace it by calling `codegen` package class from Ant task.
noskill
reviewed
Dec 27, 2019
| if (!parent.isDirectory() && !parent.mkdirs()) { | ||
| throw new IOException("failed to create directory " + parent); | ||
| } | ||
| try (OutputStream o = Files.newOutputStream(f.toPath())) { |
There was a problem hiding this comment.
Does a try without catch does anything?
Member
Author
There was a problem hiding this comment.
Yes, it is try with block, it closes OutputStream o after leaving the block. So it is equal to
OutputStream o = Files.newOutputStream(f.toPath());
try {
} finally {
o.close();
}
|
looks good to me |
Member
Author
|
Thanks @noskill ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes which were done to support Gradle and Android starting from 7.0:
plugin-coreweb3jversion to4.2.0-androidto support Android 7.0Changes are relatively simple and organized by commits. It is better to review this PR commit by commit.