Skip to content

docs(www): document Radio & fix unwired legend style - #305

Merged
Yeom-JinHo merged 3 commits into
devfrom
docs/radio-docs-jinho
Jul 24, 2026
Merged

docs(www): document Radio & fix unwired legend style#305
Yeom-JinHo merged 3 commits into
devfrom
docs/radio-docs-jinho

Conversation

@Yeom-JinHo

Copy link
Copy Markdown
Member

Changes

Radio를 문서로 추가하면서, 문서를 쓰다 드러난 컴포넌트 버그 1개를 같은 PR에서 고칩니다.

packages/radio 버그 수정 (@sipe-team/radio: patch)

  • 미적용 legend 스타일: Radio.css.tsradioGroupLegend 스타일(굵기 600·16px·marginBottom 8px·토큰 색)이 정의돼 있었지만 RadioGroup.tsx<legend>{labelText}</legend>에 className이 붙지 않아, 그룹 라벨이 브라우저 기본 스타일로 렌더됐습니다. <legend className={radioGroupLegend}>로 연결해 의도한 스타일이 실제로 적용되게 했습니다. (죽어 있던 export를 살리는 변경이라 부작용 없음)

radio.mdx

  • Installation / Usage / Examples / Anatomy / API Reference. API 표는 소스를 직접 읽고 수동 작성.
  • RadioGroup + Radio 플랫 export 구조(네임스페이스 아님)를 문서화. Uncontrolled / Controlled(value + onChangeValue) / Sizes(small·medium·large) / Disabled(그룹·개별) 예제.
  • <Preview code={...}> 예제 코드는 실제 렌더 결과와 일치.

Visuals

스크린샷 2026-07-23 오후 11 32 22

Checklist

  • Have you written the functional specifications? — 문서 자체가 명세
  • Have you written the test code? — 패키지 테스트 15개 통과. 문서는 프로덕션 빌드로 검증

Additional Discussion Points

  • 브랜치 카테고리는 docs지만 컴포넌트 fix를 포함합니다. changeset 포함(patch).

Yeom-JinHo and others added 3 commits July 23, 2026 21:01
The radioGroupLegend style was exported but never attached to the <legend>
element, so the RadioGroup label rendered with browser-default styling instead
of the intended weight/size/spacing and token color. Wire it up.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add the Radio component docs page (Preview-based MDX) covering the RadioGroup +
Radio parts, controlled/uncontrolled selection, sizes, and group/item disabled
states, plus the API reference. API table written by hand from source.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Radio hardcodes light-surface colors and does not adapt to the now dark-only
docs site, so its label text was illegible on the dark Preview stage. Wrap each
demo in a light card (LightStage, kept out of the code strings) so the control
renders as intended, and note the limitation. Also drop the stale legend note
now that the legend style is wired up.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • release/v1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d02eb3cf-60ec-4d93-828f-eca1b7970714

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/radio-docs-jinho

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f1c0fe4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sipe-team/radio Patch
@sipe-team/side Patch
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
packages/radio/src/RadioGroup.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Yeom-JinHo
Yeom-JinHo merged commit 815f497 into dev Jul 24, 2026
6 checks passed
@Yeom-JinHo
Yeom-JinHo deleted the docs/radio-docs-jinho branch July 24, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants