docs(www): document Radio & fix unwired legend style - #305
Conversation
The radioGroupLegend style was exported but never attached to the <legend> element, so the RadioGroup label rendered with browser-default styling instead of the intended weight/size/spacing and token color. Wire it up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add the Radio component docs page (Preview-based MDX) covering the RadioGroup + Radio parts, controlled/uncontrolled selection, sizes, and group/item disabled states, plus the API reference. API table written by hand from source. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Radio hardcodes light-surface colors and does not adapt to the now dark-only docs site, so its label text was illegible on the dark Preview stage. Wrap each demo in a light card (LightStage, kept out of the code strings) so the control renders as intended, and note the limitation. Also drop the stale legend note now that the legend style is wired up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: f1c0fe4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Changes
Radio를 문서로 추가하면서, 문서를 쓰다 드러난 컴포넌트 버그 1개를 같은 PR에서 고칩니다.
packages/radio버그 수정 (@sipe-team/radio: patch)Radio.css.ts에radioGroupLegend스타일(굵기 600·16px·marginBottom 8px·토큰 색)이 정의돼 있었지만RadioGroup.tsx의<legend>{labelText}</legend>에 className이 붙지 않아, 그룹 라벨이 브라우저 기본 스타일로 렌더됐습니다.<legend className={radioGroupLegend}>로 연결해 의도한 스타일이 실제로 적용되게 했습니다. (죽어 있던 export를 살리는 변경이라 부작용 없음)radio.mdxRadioGroup+Radio플랫 export 구조(네임스페이스 아님)를 문서화. Uncontrolled / Controlled(value + onChangeValue) / Sizes(small·medium·large) / Disabled(그룹·개별) 예제.<Preview code={...}>예제 코드는 실제 렌더 결과와 일치.Visuals
Checklist
Additional Discussion Points
docs지만 컴포넌트 fix를 포함합니다. changeset 포함(patch).