Skip to content

fix(tooltip): Tooltip 문서 추가 및 SSR/ref 버그 수정 - #315

Merged
3o14 merged 4 commits into
devfrom
docs/add-components
Jul 28, 2026
Merged

fix(tooltip): Tooltip 문서 추가 및 SSR/ref 버그 수정#315
3o14 merged 4 commits into
devfrom
docs/add-components

Conversation

@3o14

@3o14 3o14 commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary

Tooltip 컴포넌트의 문서 페이지를 추가합니다.
문서를 작성하는 과정에서 발견한 Tooltip 버그 수정 사항이 담긴 PR입니다.

  • createPortal을 조건 없이 호출해서 생기던 SSR 크래시 위험
  • tooltipContent가 비어있을 때 전달된 ref가 끊기던 문제

Changes

  • Tooltip 문서 페이지 추가: 설치, 사용법, Placement/Controlled visibility/Custom styling/asChild 예제, Anatomy, API Reference, Accessibility, Known limitations
  • SSR 크래시 수정: document가 존재하기 전에는 실행되지 않도록 mounted 플래그로 createPortal 호출을 지연
  • ref 끊김 수정: tooltipContent가 falsy여도 트리거의 ref/이벤트 핸들러 연결은 그대로 유지하고, 툴팁 마크업만 생략하도록 변경
  • tooltipContent가 비어있을 때 ref가 정상 forwarding되는지 확인하는 회귀 테스트 추가

Visuals

localhost_3000_docs_components_tooltip (1)

@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6db929e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sipe-team/tooltip Patch
@sipe-team/side Patch
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • release/v1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 180bbfe5-ccc2-42bb-87e9-bf9c4749eb98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/add-components

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
packages/tooltip/src/Tooltip.test.tsx 100.00% <100.00%> (ø)
packages/tooltip/src/Tooltip.tsx 94.05% <100.00%> (+0.24%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@3o14
3o14 merged commit 8a5114c into dev Jul 28, 2026
6 checks passed
@3o14
3o14 deleted the docs/add-components branch July 28, 2026 09:44
@3o14 3o14 changed the title docs(tooltip): Tooltip 문서 추가 및 SSR/ref 버그 수정 fix(tooltip): Tooltip 문서 추가 및 SSR/ref 버그 수정 Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants