fix: heartbeat completion shows LLM result instead of garbled streaming fragment

[dj-oyu]

Summary

• Heartbeat (SendResponse: false) tasks left a garbled streaming status bubble on Telegram because no final non-status message triggered cleanup
• The "Task completed" notification showed the heartbeat prompt instead of the LLM response
• Added Result/streamedChunks fields to activeTask, store the LLM response summary after the loop, publish a clean status replacement for background tasks that streamed, and use task.Result in the completion notification

Test plan

• go build ./... / go test ./... / go vet ./... — all pass
• Trigger heartbeat via Telegram, confirm streaming preview shows during execution
• After completion, verify status bubble shows actual result (not garbled fragment with block cursor)
• Verify "Task completed" notification shows LLM response summary, not the heartbeat prompt

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes heartbeat completion UX by ensuring background/heartbeat tasks publish a clean final message (instead of leaving a garbled streaming fragment) and by using the actual LLM result in “Task completed” notifications. The PR also introduces broader infrastructure around streaming/status messages, worktree-based git tools, orchestration UI support, and observability utilities.

Changes:

• Track and replace streaming/status messages so heartbeat/background tasks clean up correctly and completion notifications show the final result.
• Add new tools (git push / create PR / dev preview / bg monitor) and supporting git worktree helpers.
• Add Mini App WebSocket endpoints (logs + orchestration), log ring-buffer + subscription, and token-usage stats tracking.

Reviewed changes

Copilot reviewed 86 out of 110 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
pkg/tools/gitpush.go	Adds a safe worktree-restricted git_push tool.
pkg/tools/filesystem_test.go	Updates filesystem tests and adds validatePath error-content coverage.
pkg/tools/filesystem.go	Improves validatePath error, resolves FS per-path, and wraps ReadDir errors.
pkg/tools/edit_test.go	Updates test comments to match new FS abstractions.
pkg/tools/edit.go	Routes edit/append through resolveFS for correct sandbox/host dispatch.
pkg/tools/dev_preview.go	Adds tool to control Mini App dev reverse proxy targets.
pkg/tools/cron.go	Minor builder refactor for job listing output.
pkg/tools/createpr_test.go	Adds unit tests for create_pr tool behavior and preset allowlists.
pkg/tools/createpr.go	Adds create_pr async tool with CI polling via gh pr checks.
pkg/tools/bg_monitor_test.go	Adds tests for background process monitoring tool behavior.
pkg/tools/bg_monitor.go	Adds bg_monitor tool for listing/watching/tailing bg exec output.
pkg/tools/base.go	Introduces optional StatusProvider interface for runtime status injection.
pkg/tailscale/detect_test.go	Adds tests for parsing Tailscale hostname.
pkg/tailscale/detect.go	Adds Tailscale hostname detection + cert fetching helpers.
pkg/stats/tracker_test.go	Adds tests for stats persistence, rolling, reset, and formatting.
pkg/stats/tracker.go	Adds persistent token-usage tracker with periodic flush.
pkg/skills/search_cache.go	Preallocates cache maps/slices for less allocation churn.
pkg/skills/registry.go	Preallocates merged results for SearchAll to reduce allocations.
pkg/skills/loader.go	Switches to strings.Builder for skill context/summary assembly.
pkg/skills/clawhub_registry.go	Uses strconv.Itoa for limit param formatting.
pkg/session/manager_test.go	Adds tests for history sanitization around tool-call ordering.
pkg/session/manager.go	Adds history sanitization + deferred write-behind persistence hooks.
pkg/providers/types.go	Adds streaming types and StreamingProvider interface.
pkg/providers/tool_call_extract.go	Adds fuzzy XML tool-call extraction + stripping helpers.
pkg/providers/protocoltypes/types.go	Adds StreamEvent + StreamToolCallDelta protocol types.
pkg/providers/http_provider.go	Adds options-based HTTP provider ctor; XML tool-call fallback; streaming passthrough.
pkg/providers/factory_test.go	Adds tests for CreateProviderByName behavior.
pkg/providers/factory_provider.go	Adds provider options (streaming, timeout, RPM throttle) and MiniMax protocol support.
pkg/providers/factory.go	Refactors selection resolver and adds CreateProviderByName.
pkg/providers/codex_cli_provider.go	Avoids extra string conversion when embedding JSON parameters.
pkg/providers/claude_cli_provider_test.go	Adds extensive tests for XML tool-call extract/strip behavior.
pkg/providers/claude_cli_provider.go	Avoids extra string conversion when embedding JSON parameters.
pkg/orch/state.go	Defines typed agent lifecycle states for orchestration UI.
pkg/orch/reporter_test.go	Adds tests verifying reporter mappings and noop safety.
pkg/orch/reporter.go	Adds AgentReporter interface + noop implementation.
pkg/orch/broadcaster_test.go	Adds tests for event delivery, snapshot behavior, and non-blocking publish.
pkg/orch/broadcaster.go	Adds orchestration event broadcaster + live agent snapshot.
pkg/miniapp/ws.go	Adds WebSocket log streaming and orchestration event streaming.
pkg/miniapp/types.go	Adds Mini App API types + state notifier for SSE.
pkg/miniapp/static/map.js	Adds “orchestration room” canvas map rendering logic.
pkg/miniapp/miniapp.go	Adds Mini App handler with routes and static embedding.
pkg/miniapp/logs.go	Adds log snapshot tar.gz creation + download + cleanup.
pkg/miniapp/auth.go	Adds Telegram WebApp initData validation + allowlist enforcement.
pkg/miniapp/api.go	Adds Mini App JSON APIs + SSE state stream.
pkg/logger/logger_test.go	Adds tests for ring buffer, RecentLogs, subscriptions, and sanitization.
pkg/logger/logger.go	Adds ring buffer, subscriptions, field sanitization, and RecentLogs/ParseLevel.
pkg/heartbeat/service.go	Adds heartbeat notification suppression + think-block stripping safety net.
pkg/health/server.go	Exposes mux + adds TLS start helper.
pkg/git/worktree_test.go	Adds tests for worktree helpers and disposal/merge/prune behavior.
pkg/git/worktree.go	Adds worktree creation/disposal/merge/prune + branch name sanitization.
pkg/config/migration.go	Preallocates provider→model_list conversion slice.
pkg/config/defaults.go	Adds default TaskReminderInterval.
pkg/config/config_test.go	Adds tests for plan model parsing and override behavior.
pkg/config/config.go	Adds plan-model config fields, telegram webapp URL, stream flag, and model ref lookup.
pkg/channels/telegram/telegram_commands.go	Updates help text for new Telegram commands.
pkg/channels/telegram/telegram.go	Adds SendWithID for message tracking/editing.
pkg/channels/slack/slack.go	Refactors content building to reduce string churn.
pkg/channels/pico/pico.go	Adds SendWithID with generated message IDs.
pkg/channels/manager.go	Adds status/task message tracking + editing flows; moves webhooks onto health mux.
pkg/channels/interfaces.go	Adds MessageSenderWithID interface.
pkg/channels/discord/discord.go	Adds SendWithID for Discord.
pkg/bus/types.go	Adds status/task flags and IDs to outbound messages.
pkg/agent/session_tracker_test.go	Adds tests for session activity tracking APIs.
pkg/agent/session_tracker.go	Adds active-session tracker for coordination/observability.
pkg/agent/loop_reporter_test.go	Adds tests for orchestration event emission by agent loop.
pkg/agent/instance.go	Registers new tools, adds orchestration defaults, plan-model selection, and worktree lifecycle.
docs/plan-interview-improvements.md	Adds design notes for plan interview improvements.
cmd/picoclaw/internal/gateway/command.go	Adds CLI flags for orchestration and stats.
cmd/picoclaw/internal/agent/helpers.go	Adds CLI orchestration enablement wiring.
cmd/picoclaw/internal/agent/command.go	Adds --orchestration flag to agent command.
Makefile	Adds build/install hints and additional build targets.
.claude/settings.local.json	Adds Claude local settings/permissions file.

Comments suppressed due to low confidence (3)

pkg/tools/filesystem.go:39

• The workspace path is interpolated without quoting, which can be hard to read (especially with spaces) and ambiguous. Consider using %q (or a clearer ... outside workspace: <path> format) so callers can reliably see the exact boundary value.

			return "", fmt.Errorf("access denied: path outside workspace %s", absWorkspace)

pkg/miniapp/logs.go:88

• There are duplicated comment lines for apiLogsSnapshotDownload and cleanOldSnapshots. Please remove the duplicates to keep the file’s documentation clean and avoid confusion during future edits.

// apiLogsSnapshotDownload serves a snapshot tar.gz file.

// apiLogsSnapshotDownload serves a snapshot tar.gz file.

pkg/miniapp/logs.go:118

• There are duplicated comment lines for apiLogsSnapshotDownload and cleanOldSnapshots. Please remove the duplicates to keep the file’s documentation clean and avoid confusion during future edits.

// cleanOldSnapshots removes snapshot files older than maxAge.

// cleanOldSnapshots removes snapshot files older than maxAge.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The build-whatsapp-native target is defined twice in the Makefile. GNU Make will treat this as an override (and may warn), and only the latter recipe will apply, which is likely unintended. Remove the duplicate target (or merge the recipes) so there is exactly one build-whatsapp-native definition.

[Copilot]

The build-whatsapp-native target is defined twice in the Makefile. GNU Make will treat this as an override (and may warn), and only the latter recipe will apply, which is likely unintended. Remove the duplicate target (or merge the recipes) so there is exactly one build-whatsapp-native definition.

Suggested change

	## build-whatsapp-native: Build with WhatsApp native (whatsmeow) support; larger binary
	build-whatsapp-native: generate
	## build-whatsapp-native-all: Build with WhatsApp native (whatsmeow) support for multiple platforms; larger binaries
	build-whatsapp-native-all: generate

[Copilot]

Timestamp formatting changed from UTC to local time (time.Now() vs time.Now().UTC()). This can break ordering/correlation across machines and make logs ambiguous without an offset. Prefer time.Now().UTC().Format(time.RFC3339) (or RFC3339Nano) to keep timestamps consistent.

Suggested change

	Timestamp: time.Now().Format(time.RFC3339),
	Timestamp: time.Now().UTC().Format(time.RFC3339),

[Copilot]

SanitizeHistory validates tool-result groups using only set membership (expectedIDs[next.ToolCallID]) but does not ensure each expected ToolCallID appears exactly once. If the next messages duplicate one tool ID (e.g., tool=a, tool=a) the group will be treated as valid even though another expected tool result is missing. Fix by tracking seen IDs (or deleting from expectedIDs as they’re matched) and requiring that all expected IDs are matched exactly once.

Suggested change

	// Peek ahead: the next `needed` messages must all be tool results with matching IDs
	groupOK := true
	if i+needed >= len(history) {
	groupOK = false
	} else {
	for j := 0; j < needed; j++ {
	next := history[i+1+j]
	if next.Role != "tool" || !expectedIDs[next.ToolCallID] {
	groupOK = false
	break
	}
	}
	// Peek ahead: the next `needed` messages must all be tool results with matching IDs,
	// and each expected ID must appear exactly once.
	groupOK := true
	if i+needed >= len(history) {
	groupOK = false
	} else {
	for j := 0; j < needed; j++ {
	next := history[i+1+j]
	if next.Role != "tool" {
	groupOK = false
	break
	}
	if !expectedIDs[next.ToolCallID] {
	// Either this ID was never expected, or it has already been matched.
	groupOK = false
	break
	}
	// Mark this ID as consumed so it cannot be matched again.
	delete(expectedIDs, next.ToolCallID)
	}
	// After consuming `needed` tool messages, all expected IDs must have been matched exactly once.
	if groupOK && len(expectedIDs) != 0 {
	groupOK = false
	}

[Copilot]

SanitizeHistory validates tool-result groups using only set membership (expectedIDs[next.ToolCallID]) but does not ensure each expected ToolCallID appears exactly once. If the next messages duplicate one tool ID (e.g., tool=a, tool=a) the group will be treated as valid even though another expected tool result is missing. Fix by tracking seen IDs (or deleting from expectedIDs as they’re matched) and requiring that all expected IDs are matched exactly once.

Suggested change

	// Peek ahead: the next `needed` messages must all be tool results with matching IDs
	groupOK := true
	if i+needed >= len(history) {
	groupOK = false
	} else {
	for j := 0; j < needed; j++ {
	next := history[i+1+j]
	if next.Role != "tool" || !expectedIDs[next.ToolCallID] {
	groupOK = false
	break
	}
	}
	// Peek ahead: the next `needed` messages must all be tool results with matching IDs,
	// and each expected ID must appear exactly once.
	groupOK := true
	if i+needed >= len(history) {
	groupOK = false
	} else {
	seen := make(map[string]bool, needed)
	for j := 0; j < needed; j++ {
	next := history[i+1+j]
	id := next.ToolCallID
	if next.Role != "tool" || !expectedIDs[id] || seen[id] {
	groupOK = false
	break
	}
	seen[id] = true
	}
	if groupOK && len(seen) != needed {
	groupOK = false
	}

[Copilot]

git ls-remote origin <pattern> matches by pattern and can yield false positives (e.g., tags or similarly-prefixed refs). If the intent is to verify the remote branch exists, prefer querying the fully-qualified ref (e.g., refs/heads/<branch>). That makes the push-precondition check accurate.

Suggested change

	checkCmd := exec.CommandContext(checkCtx, "git", "ls-remote", "--exit-code", "origin", branch)
	remoteRef := "refs/heads/" + branch
	checkCmd := exec.CommandContext(checkCtx, "git", "ls-remote", "--exit-code", "origin", remoteRef)

[Copilot]

The tool description/parameters state that target 'Must be a localhost URL', but Execute() does not enforce that. If DevTargetManager doesn’t strictly validate, this could open SSRF-style proxying to arbitrary hosts. Validate target in the tool (parse URL, require loopback/localhost hostname, reject non-http(s), and disallow credentials) before calling RegisterDevTarget.

[Copilot]

Both error paths lose important context: the parse error isn’t included, and the underlying Telegram API error is discarded on send failure. Include the original err in the wrapped error (while still wrapping the sentinel error) so logs/debugging can pinpoint the root cause.

[Copilot]

Both error paths lose important context: the parse error isn’t included, and the underlying Telegram API error is discarded on send failure. Include the original err in the wrapped error (while still wrapping the sentinel error) so logs/debugging can pinpoint the root cause.

[Copilot]

A settings.local.json file typically contains machine/user-local permissions and environment identifiers and is usually not intended to be committed. This can inadvertently leak local environment details and encourages relying on developer-specific config. Consider removing it from the repo and adding it to .gitignore, and (if needed) commit a sanitized template file instead.