Skip to content

Fix Cadente accept retry stack overflow - #33

Merged
CypherPotato merged 2 commits into
mainfrom
feat/fix-cadente-accept-retry
May 24, 2026
Merged

Fix Cadente accept retry stack overflow#33
CypherPotato merged 2 commits into
mainfrom
feat/fix-cadente-accept-retry

Conversation

@CypherPotato

@CypherPotato CypherPotato commented May 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace recursive accept re-entry with loop-based synchronous accept processing
  • Re-arm accepts inline for immediate success and per-connection transient failures such as ConnectionReset, ConnectionAborted, and NetworkReset
  • Use a small delayed retry only for listener-level AcceptAsync failures
  • Clear reused SocketAsyncEventArgs.AcceptSocket before the next accept

Fixes #32.

Validation

  • dotnet build cadente\Sisk.Cadente\Sisk.Cadente.csproj -c Debug --no-restore
  • dotnet build cadente\Sisk.Cadente.CoreEngine\Sisk.Cadente.CoreEngine.csproj -c Debug --no-restore
  • git diff --check -- cadente/Sisk.Cadente/HttpHost.cs

Note: Android/emulator reproduction was not run locally.

@CypherPotato
CypherPotato force-pushed the feat/fix-cadente-accept-retry branch 2 times, most recently from 9cf73d6 to 600aa37 Compare May 22, 2026 22:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 600aa37e8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cadente/Sisk.Cadente/HttpHost.cs Outdated
@CypherPotato
CypherPotato force-pushed the feat/fix-cadente-accept-retry branch 2 times, most recently from 25fe413 to 8776b8c Compare May 24, 2026 19:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8776b8c12d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cadente/Sisk.Cadente/HttpHost.cs
@CypherPotato
CypherPotato force-pushed the feat/fix-cadente-accept-retry branch from 8776b8c to 3304225 Compare May 24, 2026 19:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3304225f49

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cadente/Sisk.Cadente/HttpHost.cs Outdated
@CypherPotato
CypherPotato merged commit 2a6f03a into main May 24, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stackoverflow-Exception in HttpHost.cs when disconnecting Wifi using MAUI-App with Android

1 participant