Fail-closed default for monitoring dashboard authentication - #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ApplicationMonitorwhere omitting a credential validator allowed any syntactically valid Basic credentials to be accepted and exposed logs/health data.Description
AuthenticateAccountAsyncinextensions/Sisk.Monitoring/ApplicationMonitor.csto returnfalsewhenCredentialValidatorisnull, preserving validator behavior when provided (AuthenticateAccountAsyncnow fails closed by default).Testing
dotnet build extensions/Sisk.Monitoring/Sisk.Monitoring.csproj -c Debug; the build was attempted but failed due to a missing sibling dependencytyped-components/src/TinyComponents.csproj, which is unrelated to this one-line auth logic change.Codex Task