Count differing pixels without materializing them#2536
Merged
Conversation
compare() is the hot path of frame processing — every duplicate-elimination, render-start and orange-frame check runs through it for every frame pair. It only needs the number of differing pixels, but argwhere materializes an index array of every matching pixel, which is most of the frame on every call. count_nonzero on the boolean mask returns the same number with no allocation. Verified byte-identical metrics on a real recording. Co-authored-by: Claude Fable 5 noreply@anthropic.com Change-Id: I2e5f31ee03f7c556d14a13937a659c2ebba58fe9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compare() is the hot path of frame processing — every duplicate-elimination, render-start and orange-frame check runs through it for every frame pair. It only needs the number of differing pixels, but argwhere materializes an index array of every matching pixel, which is most of the frame on every call. count_nonzero on the boolean mask returns the same number with no allocation. Verified byte-identical metrics on a real recording.
Co-authored-by: Claude Fable 5 noreply@anthropic.com
Change-Id: I2e5f31ee03f7c556d14a13937a659c2ebba58fe9