Drop unused fast-crc32c dependency#4735
Merged
Merged
Conversation
We used to pull in fast-crc32c because the old @google-cloud/storage client could detect it as a native addon and use it to speed up CRC32C hashing on uploads. The modern @google-cloud/storage (we're on 7.19) ships its own pure-JS CRC32C implementation and no longer reads fast-crc32c at all — it's not in its deps, optionalDependencies or peerDependencies, and nothing in sitespeed.io imports it directly. Removing it shrinks the dependency tree and stops shipping a native addon that's no longer doing any work. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to pull in fast-crc32c because the old @google-cloud/storage
client could detect it as a native addon and use it to speed up CRC32C
hashing on uploads. The modern @google-cloud/storage (we're on 7.19)
ships its own pure-JS CRC32C implementation and no longer reads
fast-crc32c at all — it's not in its deps, optionalDependencies or
peerDependencies, and nothing in sitespeed.io imports it directly.
Removing it shrinks the dependency tree and stops shipping a native
addon that's no longer doing any work.
Co-authored-by: Claude noreply@anthropic.com