Drop ora in favour of a tiny in-tree blinking-dot spinner#4740
Merged
Conversation
ora is only used by one CLI flow (--api.add / --api.addAndGetResult) to show progress while polling the test result. For that single pixel of UX we were pulling ora plus its exclusive transitive deps (cli-cursor, cli-spinners, log-symbols, is-interactive, stdin-discarder, restore-cursor, onetime, mimic-function). The replacement at lib/support/spinner.js is ~60 lines: a blinking dot toggling between '●' and ' ' on stderr every 500ms while a request is in flight, finishing with '✔ text' on success or '✖ text' on failure. It exposes the same surface the API code expects (start, text setter, color setter as a no-op, succeed, fail) and falls back to plain "starting line, final line" output when stderr isn't a TTY, so CI logs stay readable. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ora is only used by one CLI flow (--api.add / --api.addAndGetResult)
to show progress while polling the test result. For that single
pixel of UX we were pulling ora plus its exclusive transitive deps
(cli-cursor, cli-spinners, log-symbols, is-interactive,
stdin-discarder, restore-cursor, onetime, mimic-function).
The replacement at lib/support/spinner.js is ~60 lines: a blinking
dot toggling between '●' and ' ' on stderr every 500ms while a
request is in flight, finishing with '✔ text' on success or
'✖ text' on failure. It exposes the same surface the API code
expects (start, text setter, color setter as a no-op, succeed,
fail) and falls back to plain "starting line, final line" output
when stderr isn't a TTY, so CI logs stay readable.
Co-authored-by: Claude noreply@anthropic.com