Bring back visual-change markers in the waterfall#4755
Merged
Conversation
The waterfall-tools renderer that replaced PerfCascade in #4614 only draws vertical lines for a fixed set of page-event names. Browsertime still emits _firstVisualChange / _lastVisualChange / _visualComplete85 on the HAR, but those don't match any of the renderer's known names, so the visual-change markers that have been part of the waterfall since 2016 silently disappeared with the renderer swap. Bump the waterfall-tools pin to pick up its new hover-on-metric-line callbacks, hoist the three visual-change values into the HAR's user-timing-marks bag so they ride the rendering path that does draw vertical lines, default the marks toggle on (and rename it to "Marks & visual metrics" so users see why their visual-change lines depend on it), and extend our onHover so the new tooltip identifies which metric or user mark the cursor is on instead of only ever showing request URLs. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The waterfall-tools renderer that replaced PerfCascade in #4614 only
draws vertical lines for a fixed set of page-event names. Browsertime
still emits _firstVisualChange / _lastVisualChange / _visualComplete85
on the HAR, but those don't match any of the renderer's known names,
so the visual-change markers that have been part of the waterfall
since 2016 silently disappeared with the renderer swap.
Bump the waterfall-tools pin to pick up its new hover-on-metric-line
callbacks, hoist the three visual-change values into the HAR's
user-timing-marks bag so they ride the rendering path that does draw
vertical lines, default the marks toggle on (and rename it to "Marks
& visual metrics" so users see why their visual-change lines depend
on it), and extend our onHover so the new tooltip identifies which
metric or user mark the cursor is on instead of only ever showing
request URLs.
Co-authored-by: Claude noreply@anthropic.com