Fix plotSpectra axis limits#343
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #340.
plotSpectra()was pinning the y-axis lower limit to1e-20even whenylim[1]was not specified, causing a large empty region below the data on the log-scale plot. The1e-20threshold is now used only to filter near-zero values from the data; the y-axis auto-scales to the data range whenylim[1]isNA.wlim[1]) now depends on theresourceargument:min(params@w) / 100whenresource = TRUE(existing behaviour, to show some resource below the fish grid) andmin(params@w)whenresource = FALSE.wlimandylimparameters updated to describe this behaviour.Test plan
NA(auto-scale) whenylim[1]is not specified.wlim[1]extends belowmin(params@w)withresource = TRUEand equalsmin(params@w)withresource = FALSE.testthat::test_file("tests/testthat/test-plots.R")— 72 tests, 0 failures.🤖 Generated with Claude Code