fix(matrix): render covered-but-failing requirement as ▣, not ✗#81
Merged
Conversation
The coverage-classifier unification (2a6630a) split out a distinct "failing" cell state (covered by a non-draft TestCase whose latest verdict is fail), but the matrix glyph render was never updated — it fell through to "✗", making a covered-but-failing requirement visually indistinguishable from a true gap (no test at all). Map "failing" to "▣" ("covered, not passing"), matching the legend and the evidence-backed "covered" cell. Footer counting (failing counts as applicable-not-covered) is unchanged. Fixes qual TC-TRS-OUT-009.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Tool Qualification CI job fails on
main(v0.29.0): qualification test TC-TRS-OUT-009 — "matrix shows ✓ for passing and ▣ for covered-not-passing" — fails withfailing requirement missing ▣.Root cause
The coverage-classifier unification (
2a6630a) added a distinct"failing"cell state — a requirement covered by a non-draft TestCase whose latest ingested verdict is fail. But the matrixglyphrenderer was never updated to handle it, so"failing"fell through to"✗"— identical to a true"gap"(no test at all). A covered-but-failing requirement became visually indistinguishable from an uncovered one.Fix
Map
"failing"→"▣"("covered, not passing"), matching the legend text and the evidence-backed"covered"cell. The requirement is covered; the test just isn't passing.Footer/coverage-percentage counting is unchanged —
"failing"still counts as applicable-not-covered (the unification's intended safety-critical stance: no coverage credit for a failing test). Only the glyph distinguishes it from a gap.Verification
REQ-OUT9-FAIL-001now renders▣with evidence,✓under--linked-only(as expected).syscribecrate test suite green; clippy clean.🤖 Generated with Claude Code