New settings structure, migrate to toml configs#956
Merged
Conversation
badrogger
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the use of
config_fileas the primary configuration argument throughout the CLI codebase, replacing the previousenv_fileandenv_filepathusages. It also updates developer instructions to reflect new tooling and environment requirements, introduces settings file paths, and improves type handling for environment types. These changes improve consistency, maintainability, and developer experience.CLI argument standardization and refactoring:
Replaced all
env_file/env_filepathCLI arguments and parameters withconfig_fileacrossnode_cli/cli/node.py,node_cli/cli/fair_node.py, andnode_cli/cli/passive_fair_node.py, updating function signatures and internal usages accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Updated the
restorecommand for schains to use settings fromget_settings()and explicitly passschain_typeandenv_type, removing the--env-typeoption.Developer instructions and tooling:
.github/copilot-instructions.mdto referencepyproject.tomlfor formatting, require use ofuv runfor all commands (including linting and tests), and added instructions for exporting environment variables before running tests.Configuration and settings improvements:
Added new settings file paths (
SETTINGS_DIR,NODE_SETTINGS_PATH,INTERNAL_SETTINGS_PATH) tonode_cli/configs/__init__.pyfor future configuration management.Cleaned up unused or legacy configuration variables and imports in
node_cli/configs/__init__.py. [1] [2]Type and import enhancements:
Replaced usage of
ALLOWED_ENV_TYPESwith dynamic extraction of allowed types fromEnvTypeusingget_argsin CLI argument definitions, improving type safety and maintainability. [1] [2] [3]Added missing imports for new settings and type handling. [1] [2]