Conversation
badrogger
previously approved these changes
Apr 15, 2026
badrogger
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new utility function,
rm_legacy_containers, to help clean up legacy Docker containers with names starting withskale_. The function is integrated into several node operation workflows to ensure legacy containers are consistently removed during update and shutdown processes. Comprehensive tests for this new functionality have also been added.Docker container cleanup improvements:
rm_legacy_containersindocker_utils.pyto remove all containers with names starting withskale_using Docker's filtering capabilities.rm_legacy_containersinto the update and shutdown flows for both base and fair node operations (base.pyandfair.py), ensuring legacy containers are removed during these processes. [1] [2] [3] [4] [5]Testing enhancements:
rm_legacy_containersto the import lists in both the main code and test files. [1] [2] [3]test_rm_legacy_containers, to verify that containers with names starting withskale_are properly removed.test_get_all_skaled_containers_real, to ensure container name filtering works as expected.