fix(hooks): correct PreToolUse if-condition syntax and add explicit settings defaults - #10
Merged
Merged
Conversation
…ettings defaults The enforce-uv.sh/protect-main.sh PreToolUse entries combined multiple patterns in one `if` string (e.g. `Bash(python *)|Bash(pytest *)|...`). Per code.claude.com/docs/en/hooks, `if` holds exactly one permission rule with no `||`/list syntax, so the condition never matched and both hooks silently stopped firing -- including protect-main.sh's guardrails against force-push, direct push to main, hard resets, and broad `rm -rf`. Split each pattern into its own hook handler entry. Also add permissions.defaultMode: "default" and CLAUDE_CODE_DISABLE_BUNDLED_SKILLS="0" explicitly, matching current Claude Code defaults so they're visible and easy to customize. permissions.disableAutoMode and language are documented in the README instead, since neither has a neutral value that preserves default behavior when set explicitly.
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enforce-uv.sh/protect-main.shPreToolUseentries in.claude/settings.json: theiffield combined multiple patterns in one string (Bash(python *)|Bash(pytest *)|...), which is not valid syntax (ifholds exactly one permission rule, no||/list syntax). The condition never matched, so both hooks silently stopped firing — includingprotect-main.sh's guardrails against force-push, direct push to main, hard resets, and broadrm -rf. Split into separate hook handler entries per pattern (8 forenforce-uv.sh, 2 forprotect-main.sh).permissions.defaultMode: "default"andCLAUDE_CODE_DISABLE_BUNDLED_SKILLS="0"explicitly, matching current Claude Code defaults, so they're visible and easy to customize. Documentedpermissions.disableAutoModeandlanguagein the README instead, since neither has a neutral value that preserves default behavior when set explicitly.Test plan
python -c "import json; json.load(open('.claude/settings.json'))"— valid JSONprotect-main.shnow blocks a force-push/hard-reset/broadrm -rfattempt in a live sessionenforce-uv.shstill rewrites barepython/pytest/ruffcalls touv run ...🤖 Generated with Claude Code