Smaller fixes to IDE support#644
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo files are modified: the first improves error handling in IDE installation by propagating RStudio installation failures instead of logging and swallowing them, while the second updates user-facing display names for three IDE configurations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace the Cursor logo (currently 1.6 MB) with a smaller one taken from the branding pack at https://cursor.com/brand (`General Logos/Cube/SVG/CUBE_25D.svg`), which is also less detailed and more expressive.
Taken from the Google Antigravity logo on their website.
Use the same naming the upstream product uses.
Don't do special error handling for the RStudio IDE, treat it like all other IDEs and pass the error on.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pkg/ide/ideparse/parse.go (1)
124-128: Consider fixing "Goland" → "GoLand" for consistency.Since this PR aligns IDE names with upstream spelling, note that the official JetBrains product name uses a capital L: "GoLand". This could be addressed in a follow-up.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/ide/ideparse/parse.go` around lines 124 - 128, The DisplayName value for the IDE entry using config.IDEGoland is misspelled as "Goland"; update the DisplayName to the correct upstream product spelling "GoLand" (preserving the existing entry keys such as config.IDEGoland, Icon, Options, and Group) so the IDE listing uses the proper capitalization.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pkg/ide/ideparse/parse.go`:
- Around line 124-128: The DisplayName value for the IDE entry using
config.IDEGoland is misspelled as "Goland"; update the DisplayName to the
correct upstream product spelling "GoLand" (preserving the existing entry keys
such as config.IDEGoland, Icon, Options, and Group) so the IDE listing uses the
proper capitalization.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4fc72697-d4f3-4057-ba89-cd4db6cd752b
⛔ Files ignored due to path filters (2)
desktop/src/images/antigravity.svgis excluded by!**/*.svgdesktop/src/images/cursor.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
cmd/agent/container/setup.gopkg/ide/ideparse/parse.go
There was a problem hiding this comment.
Didn't catch this earlier but I noticed the logo should be the same size as the previous image 128px Height and Width. Let's fix that.
There was a problem hiding this comment.
Where do you see a difference in rendering? The SVGs are scaled down to something like 16x16px anyways in the IDE selection. Are they used in another place?
Either way, I'm happy to resize the SVG -- but would it change anything?
2 participants
A set of small fixes around IDE support.
Summary by CodeRabbit