Bugfix: Use Locale.ROOT for ISO8601 date formatting to prevent localized digits#126
Merged
Merged
Conversation
Member
|
Great fix, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
Date.ISO8601Format()would produce localized ISO 8601 strings depending on the user's Android device locale instead of a stable, locale-independent representation.The root of the issue was that the previous implementation used Java's default locale (
java.util.Locale.getDefault()). On devices set to languages like Arabic or Hindi, however,SimpleDateFormatautomatically localized the output:٢٠٢٦instead of2026)Example:
iOS:

Android:

Since I use these date strings as timestamps in SkipSQL, this localization broke my database layer and caused record deserialization to fail as soon as the system language was changed.
To fix the issue, I replaced
java.util.Locale.getDefault()withjava.util.Locale.ROOT. Similar to Swift'sen_US_POSIX, it avoids locale-specific number systems and ensures the output uses standard ASCII digits (0–9), making the ISO 8601 representation consistent across Android and iOS regardless of the user's device locale.Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Skip Pull Request Checklist:
swift test