Add support for lineLimit(_ limit: Int, reservesSpace: Bool) - #161
Conversation
ec47d91 to
44699f6
Compare
44699f6 to
8cd4871
Compare
aabewhite
left a comment
There was a problem hiding this comment.
Thanks! Will take a look in the next couple days when I finish my current task. Off the bat, looks great, but I think I'd prefer to put lineLimit and reservesSpace together into a single Tuple (Pair in Kotlin) in the Environment. I try to group things together when it makes sense because I worry that eventually we're going to see a perf drag from so many Environment lookups
|
I think a Tuple might be nicer, but I'm not sure it would make sense here, because https://developer.apple.com/documentation/swiftui/environmentvalues/linelimit The current released version of SkipUI can honor the And if we don't change the type, then we just have to have a second environment variable. (Right?) |
|
Ah, I didn't notice that lineLimit is one of the exposed environment values. In that case you're absolutely right to keep them separate |
aabewhite
left a comment
There was a problem hiding this comment.
One request, otherwise looks good!
8cd4871 to
f63088c
Compare
|
A couple of months later, I've resolved feedback; I think this is now ready to merge. |
|
Looks great, thanks! |
https://developer.apple.com/documentation/swiftui/view/linelimit(_:reservesspace:)
I've tested it with skiptools/skipapp-showcase#27 where it works on both Android and iOS.
swift test