Skip to content

Use ic_launcher resource for the Android notification icon#204

Merged
marcprux merged 4 commits into
skiptools:mainfrom
macshodan:main
May 8, 2025
Merged

Use ic_launcher resource for the Android notification icon#204
marcprux merged 4 commits into
skiptools:mainfrom
macshodan:main

Conversation

@macshodan

@macshodan macshodan commented May 8, 2025

Copy link
Copy Markdown
Contributor

Changed the setSmallIcon call to use a specific notifcation icon insted of the ic_laucnher one to avoid a wrong icon in the tray

Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

Changed the setSmallIcon call to use a specific notifcation icon insted of the ic_laucnher one to avoid a wrong icon in the tray
@cla-bot

cla-bot Bot commented May 8, 2025

Copy link
Copy Markdown

Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @macshodan on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file

@marcprux

marcprux commented May 8, 2025

Copy link
Copy Markdown
Member

This looks good to me, and I assume it fixed #203 to your satisfaction.

Could you add mention of this to the README? That way, it will make its way into the docs on the web site.

@cla-bot cla-bot Bot added the cla-signed label May 8, 2025
macshodan added 2 commits May 8, 2025 15:26
added fallback to default app icon if the appropriate notification icon is not found.
Added explanations for using a custom notification icon.
@macshodan

Copy link
Copy Markdown
Contributor Author

This looks good to me, and I assume it fixed #203 to your satisfaction.

Could you add mention of this to the README? That way, it will make its way into the docs on the web site.

Great!
I've updated the code to fallback to the ic_launcher resource if the notification icon is not found (otherwise the process would crash and the notification is not displayed) and added the relevant information to the README file.

@marcprux

marcprux commented May 8, 2025

Copy link
Copy Markdown
Member

Looks good! Thanks for the contribution!

@marcprux marcprux changed the title Android Notification Icon Fix Use ic_launcher resource for the Android notification icon May 8, 2025
@marcprux
marcprux merged commit 33eef1b into skiptools:main May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants