Use ic_launcher resource for the Android notification icon#204
Conversation
Changed the setSmallIcon call to use a specific notifcation icon insted of the ic_laucnher one to avoid a wrong icon in the tray
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @macshodan on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
|
This looks good to me, and I assume it fixed #203 to your satisfaction. Could you add mention of this to the README? That way, it will make its way into the docs on the web site. |
added fallback to default app icon if the appropriate notification icon is not found.
Great! |
|
Looks good! Thanks for the contribution! |
Changed the setSmallIcon call to use a specific notifcation icon insted of the ic_laucnher one to avoid a wrong icon in the tray
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Skip Pull Request Checklist:
swift test