Bugfix: Stabilize Focused Text Input Scrolling - #519
Open
fhasse95 wants to merge 1 commit into
Open
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes scrolling behavior for focused
TextFieldandTextEditorviews insideListandTable.Before this change, the list item placement animation could continue running while a focused text input was inside the scrolling row. On Android/Compose, the focused text input layout can update independently from the surrounding
LazyColumnitem placement animation. Visually, this could make the focusedTextFieldorTextEditorappear to lag behind the rest of the row while scrolling.To reproduce:
Listcontaining aTextFieldorTextEditor(e.g. the bottom text field in theFormPlaygroundof the Skip Showcase app).Below is a before/after comparison of this example:
Before:

After:

As you can see, the focused text input now scrolls together with its row after this change.
Thank you for contributing to the Skip project! Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Skip Pull Request Checklist:
swift testI used Codex to iteratively investigate and refine the fix for the focused text input scrolling issue. To verify the results, I tested multiple playground views which contain text fields or text editors in the Skip Showcase app and my own Skip app. All of these scenarios work properly after the bug fix.