Fix Travis CI #420
Merged
Fix Travis CI #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
They only change that sticks out its pinning urllib3, what issue does that resolve? |
Collaborator
Author
|
@Ashex Travis jobs for python > 3.5 have been failing with the following error: By pinning urllib3 to that version we make Travis job pass. |
Ashex
approved these changes
Nov 24, 2019
Collaborator
Ashex
left a comment
Ashex
left a comment
There was a problem hiding this comment.
These changes are pretty clear to me and solve issues I've seen crop up recently. LGTM
Contributor
|
Thank you @chillipeper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.