Skip to content

[ENH] GreyKiteForecaster - clean up tags#10571

Merged
fkiraly merged 9 commits into
mainfrom
greykite-test
Jul 18, 2026
Merged

[ENH] GreyKiteForecaster - clean up tags#10571
fkiraly merged 9 commits into
mainfrom
greykite-test

Conversation

@fkiraly

@fkiraly fkiraly commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Cleans up GreyKiteForecaster tags. Tests are still skipped.

See #10083 for failure tracking.

Copilot AI review requested due to automatic review settings July 18, 2026 16:26
@fkiraly fkiraly added the module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting label Jul 18, 2026
@fkiraly
fkiraly requested a review from SimonBlanke as a code owner July 18, 2026 16:26
@fkiraly fkiraly added the enhancement Adding new functionality label Jul 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to re-enable CI coverage for GreykiteForecaster by marking it for VM-based testing and narrowing test skips to known failing checks (tracked in #10083), rather than skipping the estimator entirely.

Changes:

  • Enables VM testing for GreykiteForecaster via the tests:vm tag.
  • Adds tests:skip_by_name entries to skip specific failing tests (notably persistence/deepcopy-related ones).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sktime/forecasting/greykite.py Outdated
Comment thread sktime/forecasting/greykite.py
@fkiraly fkiraly changed the title [ENH] enable GreyKiteForecaster tests [ENH] GreyKiteForecaster - clean up tags Jul 18, 2026
@fkiraly
fkiraly merged commit 0d7295c into main Jul 18, 2026
3 of 4 checks passed
@fkiraly
fkiraly deleted the greykite-test branch July 18, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adding new functionality module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants