Fix crash while building opencv for OSX#110
Merged
skvark merged 2 commits intoopencv:masterfrom Jul 20, 2018
Merged
Conversation
added 2 commits
July 19, 2018 11:46
…osx also sets the correct numpy version for python3.7
Member
|
Nice! Thanks a lot. I suspected that there was something overriding those params. Let's see how the builds go as I have been poking master branch today. |
|
Thanks @yonip for reporting the issue on scikit-build issue tracker and also thanks for your help to address the issue. The problem should be fixed in the upcoming release of scikit-build, then specifying either |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original crash was caused by scikit-build both prioritizes command line options over the parameters passed to the
setupfunction, and that it defaults the command line options for-DCMAKE_OSX_DEPLOYMENT_TARGETand for-DCMAKE_OSX_ARCHITECTURESwithout checking thatsetupwas passed those parameters.(this is where scikit-build defaults the command line parameters, and this is where the command line parameters are combined with the passed in parameters).
As a workaround, I overrode one function in multibuild's
common_utils.shinconfig.shthat allows for extra command line parameters to be passed to setup.py, and set the parameters only for OSX tests in.travis.yml.Also fix a later crash where
install_runcrashed on OSX builds with Python 3.7, where theTEST_DEPENDSenvironment variable defaulted tonumpy==1.11.1where Python 3.7 requiresnumpy==1.14.5.