This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Merged
Conversation
Owner
|
Looks good to me, thanks for your pull-request. Will merge when it passes the CI, and I get back home in a few hours. I suspect there's another update that needs to be done, for the case where the URL itself contains an equals. Something like this: If you add it that'd be appreciated; otherwise I'll do that myself later this evening. |
DaleFarnsworth
pushed a commit
to DaleFarnsworth/rss2email
that referenced
this pull request
Aug 4, 2020
Add a -from="email_address" flag to specify an email address that emails are sent from. If not specified, the From: address in each email will still be the same as the To: address. This commit fixes skx#13.
The bare '=' in <a href="...> was being swallowed up by the conversion to quoted-printable decoding. Change it to "=3D" which is '=' in quoted-printable encoding. Similarly if the link contains an '=' would be removed. So we encode the link in quotate-printable format. This commit fixes skx#12.
DaleFarnsworth
force-pushed
the
fix_article_html_url
branch
from
eef6ea3 to
c5fe9fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bare '=' in <a href="...> was being swallowed up by the conversion
to quoted-printable decoding. Change it to "=3D" which is '=' in
quoted-printable encoding.
This commit fixes #12.