Conversation
We previously reserved 256 bytes of stack/frame space for
functions, and then switched to calculating the real size
because that was more efficient (and correct).
Similar story here, we were blindly reserving a fixed size
for global inits, but that failed when we ran code like this
(defun fun (list (list "steve" "blah")
(list 1 2 (/ 1.0 3))
; ..
))
That would cause a segfault on startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the frame size used for global init code.
We previously reserved 256 bytes of stack/frame space for functions, and then switched to calculating the real size because that was more efficient (and correct).
Similar story here, we were blindly reserving a fixed size for global inits, but that failed when we ran code like this
That would cause a segfault on startup, as the updated
examples/globals.lisptest did, when I was experimenting with drawing graphics.Now the tests pass and no more segfault. I also switched to auto-calling the non-GC version of the
(list ..primitive. Not yet sure if that is a mistake.